Web Staff Client: Missing Print Functionality on Patron Form

Bug #1693036 reported by Terran McCanna
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

On web staff client 2.12.1:

The patron registration / edit screen is lacking the Print button that the old staff client had. It is possible to print using the browser's print function, but much of the text is overlapped and unreadable.

See attachment for example comparing the old and new print results.

(Somewhat related to https://bugs.launchpad.net/evergreen/+bug/1586088)

Revision history for this message
Terran McCanna (tmccanna) wrote :
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

I've pushed up a branch here that should resolve this: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1693036-patron-form-print-functionality

It adds a print button next to the Save button on the Patron Editor/Registration screen, and supplies a print template for workstation-side editing, as well as some documentation on how to edit the template. The print button gathers the patron in scope, so it will gather information from the fields.

tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Kyle!!!

I can't test at the moment, but I will test next week!

Revision history for this message
Terran McCanna (tmccanna) wrote :

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

I've tested this and added a branch (user/gmcharlt/lp1693036_tested) that includes signoffs and a follow-up patch to ensure that daytime phone numbers are printed properly.

There's a pending question in #evergreen whether to merge just to master for inclusion in 3.1-rc or to also target 3.0.x. I'll hold off on merging into Dan Wells weighs in.

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
milestone: none → 3.1-rc
Dan Wells (dbw2)
Changed in evergreen:
importance: Undecided → Medium
Remington Steed (rjs7)
Changed in evergreen:
assignee: Dan Wells (dbw2) → Remington Steed (rjs7)
Revision history for this message
Remington Steed (rjs7) wrote :

I tested Galen's branch and found a few small problems. Here's my sign-off branch, plus an additional commit on top:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1693036_patron_print_template

Revision history for this message
Dan Wells (dbw2) wrote :

Looks good everyone! Pushed to master for inclusion in 3.1.

I don't have any particular opinion about backporting to 3.0.x, so leaving that alone for now.

Changed in evergreen:
assignee: Remington Steed (rjs7) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.