Docker graph driver setting not honored

[Martin André]

The overcloud nodes are now supposed to run docker with overlay2 graph driver but they appear to still use devicemapper:

http://logs.openstack.org/38/462538/3/check-tripleo/gate-tripleo-ci-centos-7-ovb-containers-oooq-nv/e5d3dee/logs/oooq/overcloud-controller-0/etc/sysconfig/docker-storage.gz

and

http://logs.openstack.org/38/462538/3/check-tripleo/gate-tripleo-ci-centos-7-ovb-containers-oooq-nv/e5d3dee/logs/oooq/overcloud-controller-0/var/log/extra/docker/docker_allinfo.log.txt.gz

Possibly the setting is being overridden by docker-storage-setup.

The switch to overlay2 was enabled in https://review.openstack.org/#/c/451916/

[Steve Baker (steve-stevebaker)]

I think the puppet is just missing a notify=>Service['docker'], so docker isn't restarting to pull in the change

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/468201

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468201
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c635586477d667e29631d2d26e018620abbb3f0c
Submitter: Jenkins
Branch: master

commit c635586477d667e29631d2d26e018620abbb3f0c
Author: Steve Baker <email address hidden>
Date: Fri May 26 11:12:10 2017 +1200

    Restart docker after changing storage driver

    This likely explains why CI appears to still be running the
    devicemapper driver even though overlay2 is now the default.

    Change-Id: Ic2d80bae1fddbdb1c80bae297031521dd78d896a
    Closes-Bug: #1692502

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/469076