[21.10 FEAT] libvirt: Add support for PCI multifunction adapter hot plug/unplug in libvirt

[bugproxy]

== Comment: #0 - Frank P. Novak <email address hidden> - 2016-06-29 18:37:58 ==
Libvirt currently supports cold passthrough of PCI multifunction adapters. However, it doesn't support proper hot plug/unplug of all the functions of these adapters.

This bug tracks the development work needed to enable PCI hot plug/unplug of multifunction adapters in libvirt.

== Comment: #13 - Leonardo Augusto Guimaraes Garcia <email address hidden> - 2017-01-18 18:30:50 ==
Shiva has been working on this one upstream. However, other changes going upstream related to the multi-PHB support in ppc64 are probably going to affect the work being done by Shiva. Given that this is not being ready upstream soon, moving this one to Ubuntu --17.10-- to 20.10.

[Christian Ehrhardt  (paelzer)]

Hi,
thanks for opening this bug to track that work.
I read this is known to be incomplete yet, please let us know when there is any code/release that be considered for inclusion.

[Christian Ehrhardt  (paelzer)]

Ping - Polling for related commit ID's for p9 support

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-06-14 10:16 EDT-------
Hi Christian,

This is not POWER9 specific. Actually, not even Power specific. This is still being worked upstream.

[Christian Ehrhardt  (paelzer)]

Thanks to clarify - I expected just as much but wanted to be sure.
So we keep it open and incomplete for now and might punt it to 18.04 later on if it takes more time.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-07-20 05:08 EDT-------
*** Bug 156863 has been marked as a duplicate of this bug. ***

[Frank Heimes (fheimes)]

The mentioned "Bug 156863" is obviously a bugzilla bug.
Is it also a duplicate of another bug in Launchpad?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-08-07 15:22 EDT-------
(In reply to comment #22)
> The mentioned "Bug 156863" is obviously a bugzilla bug.
> Is it also a duplicate of another bug in Launchpad?

No. It has been marked as a duplicate by error.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-09-14 10:55 EDT-------
Madhu,

Could you please point the upstream commit IDs for this feature? Or, given that Ubuntu 17.10 is using libvirt 3.6 now, hopefully this already has the needed commits.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-10-03 09:51 EDT-------
Hi Leonardo, This is not yet upstream, and will be too late for 17.10, so re-targeting to 18.04.

Thanks,
Shiva

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-02-12 00:27 EDT-------
@shiv will this be targeted for Ubuntu 18.04?

[Manoj Iyer (manjo)]

Looks like we are still waiting on the code to be upstreamed. Any updates on the upstream status ?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-02-14 13:40 EDT-------
This is not upstream yet. Shiva is working on it.

[Manoj Iyer (manjo)]

IBM, 18.10 feature freeze is on the 23rd of Aug, any news on the upstream status of this patch?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-08-21 01:20 EDT-------
Patches posted upstream and pending review.

[Manoj Iyer (manjo)]

Have the patches made its way upstream? if so could you please post those links here?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-12-06 02:13 EDT-------
The latest patch set is here:
https://www.redhat.com/archives/libvir-list/2018-March/author.html#00729

For now will also reduce the priority and will look into the priority of this more.

[Andrew Cloke (andrew-cloke)]

From looking at the maillist in comment #16, it would appear that this patchset is still in discussion.

[Andrew Cloke (andrew-cloke)]

Marking as incomplete while waiting for the patchsets to land upstream.

[Andrew Cloke (andrew-cloke)]

Updated title to reflect new 19.10 target.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-07-01 10:27 EDT-------
Current progress: I chose to split the patch series into smaller chunks to make it easier to review and to be pushed. First part, 10 patches (out of 30) was sent to the Libvirt mailing list last Wednesday, June 26th [1]. It is still pending review. Before sending this first part I've sent a RFC to the mailing list reviving the discussion [2], and the community seems to approve it (or, at least, not rejecting it fiercely).

Still, I am not sure about the 19.10 target. Feature freeze for 19.10 is August 22nd (correct me if I'm wrong), so we have 30 patches to be pushed in 8 weeks. It is doable, but depends on how fast I can work it with the community on the reviews.

[1] https://www.redhat.com/archives/libvir-list/2019-June/msg01268.html
[2] https://www.redhat.com/archives/libvir-list/2019-June/msg00703.html

[Christian Ehrhardt  (paelzer)]

It's your targets/milestones - if 20.04 makes more sense for your upstreaming (and it seems it does) that seems fine for us.

[Andrew Cloke (andrew-cloke)]

Moving to target 20.04.

[Christian Ehrhardt  (paelzer)]

FYI: see [1] and related posts for further upstream activity.

[1]: https://www.redhat.com/archives/libvir-list/2019-August/msg00640.html

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-09-13 08:12 EDT-------
The first set of patches of the feature was pushed to Libvirt this last Monday, Sept 9th. The set contained enhancements/fixes in the test framework for the more sophisticated PCI multifunction tests that will come.

It is also worth mentioning is that I proposed a change in the PCI multifunction hot-unplug mechanism of the pseries machine in QEMU. The change was accepted and it is upstream. You can read more about it here [1], but the result is that the design of the multifunction hot-unplug in Libvirt can be simplified after this change.

I'll be re-testing the whole patch series after the recent changes in Libvirt master branch, then I'll make further adjustments considering that QEMU change I mentioned above. I'll end up submitting what's left of the feature in a single series, instead of breaking down in smaller pieces, given that the remaining patches are now quite tied up together.

[1] https://github.com/qemu/qemu/commit/02a1536eee333123c7735cd36484da53b860fbb7

[Christian Ehrhardt  (paelzer)]

Hi,
I have not seen the final code in v6.0.0 of libvirt.
Was it renamed so I can't find it or didn't it make upstream yet?

If so are they upstream soon for a cherry-pick onto v6.0.0 which we plan for 20.04 or will this feature have to be punted to Ubuntu 20.10?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-01-13 10:25 EDT-------
Hey,

(In reply to comment #51)
> Hi,
> I have not seen the final code in v6.0.0 of libvirt.
> Was it renamed so I can't find it or didn't it make upstream yet?

Unfortunately it didn't make it yet. I've done a lot of cleanups and
prep for these patches, but the core feature is still pending
a new rebase and re-submit to the ML.

>
> If so are they upstream soon for a cherry-pick onto v6.0.0 which we plan for
> 20.04 or will this feature have to be punted to Ubuntu 20.10?

Ubuntu 20.10 seems more sane at this point.

[Frank Heimes (fheimes)]

Thx 'danielhb' for the feedback - changing ticket now to 20.10.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-01-30 11:52 EDT-------
Feature was submitted for approval as v2:

([PATCH v2 00/21] PCI Multifunction hotplug/hotunplug support)

https://www.redhat.com/archives/libvir-list/2020-January/msg01377.html

I gave up on trying to fragment the feature in small pieces. Sending all patches allows the community to see the entire picture and review/test the feature as a whole.

[Christian Ehrhardt  (paelzer)]

I can't find it in libvirt 6.6 even - unless there were massive renames this didn't land upstream yet. Please let us know if it already did or if there is anew schedule/plan to get it landed.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-08-17 12:17 EDT-------
According to development, patches are not ready for 20.10, therefore moving target to 21.04.

[Frank Heimes (fheimes)]

Scanning the upstream libvirt git tree (https://libvirt.org/git/?p=libvirt.git) it looks like the patch set "[PATCH v2 00/21] PCI Multifunction hotplug/hotunplug support" is still not upstream accepted, i.e. not with libvirt 6.9 (which is the planned libvirt target release for hirsute/21.04).
Hence it's very unlikely that this can be picked up by and delivered with Ubuntu 21.04 (hirsute).

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2021-05-03 15:45 EDT-------
There is no intent from our end to keep pursuing this feature anymore.

A community bug was created in gitlab (https://gitlab.com/libvirt/libvirt/-/issues/160) to report all the work done in this feature during this time. The community is then free to implement it or not.