[ubuntu-14.04] contrail-status doesn't show correct status for contrail-database

[Sundaresan Rajangam]

contrail-status shows contrail-database as active after stopping the service.

root@nodec40(analyticsdb):/# contrail-status
vRouter is PRESENT

== Contrail Database ==
contrail-database: active

contrail-database-nodemgr active
kafka active

root@nodec40(analyticsdb):/# ps aux | grep cassandra
root 2855 0.0 0.0 8868 788 ? S+ 17:25 0:00 grep --color=auto cassandra
cassand+ 32224 12.1 26.7 9287600 8752068 ? SLl 17:17 0:58 java -ea -javaagent:/usr/share/cassandra/lib/jamm-0.3.0.jar -XX:+CMSClassUnloadingEnabled -XX:+UseThreadPriorities -XX:ThreadPriorityPolicy=42 -Xms7973M -Xmx7973M -Xmn400M -XX:+HeapDumpOnOutOfMemoryError -Xss256k -XX:StringTableSize=1000003 -XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=1 -XX:CMSInitiatingOccupancyFraction=75 -XX:+UseCMSInitiatingOccupancyOnly -XX:+UseTLAB -XX:+PerfDisableSharedMem -XX:CompileCommandFile=/etc/cassandra/hotspot_compiler -XX:CMSWaitDuration=10000 -XX:+CMSParallelInitialMarkEnabled -XX:+CMSEdenChunksRecordAlways -XX:CMSWaitDuration=10000 -XX:+UseCondCardMark -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintHeapAtGC -XX:+PrintTenuringDistribution -XX:+PrintGCApplicationStoppedTime -XX:+PrintPromotionFailure -Xloggc:/var/log/cassandra/gc.log -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=10M -Djava.net.preferIPv4Stack=true -Dcassandra.jmx.local.port=7199 -XX:+DisableExplicitGC -Djava.library.path=/usr/share/cassandra/lib/sigar-bin -Dlogback.configurationFile=logback.xml -Dcassandra.logdir=/var/log/cassandra -Dcassandra.storagedir= -Dcassandra-pidfile=/var/run/cassandra/cassandra.pid -cp /etc/cassandra:/usr/share/cassandra/lib/ST4-4.0.8.jar:/usr/share/cassandra/lib/airline-0.6.jar:/usr/share/cassandra/lib/antlr-runtime-3.5.2.jar:/usr/share/cassandra/lib/cassandra-driver-core-2.2.0-rc2-SNAPSHOT-20150617-shaded.jar:/usr/share/cassandra/lib/commons-cli-1.1.jar:/usr/share/cassandra/lib/commons-codec-1.2.jar:/usr/share/cassandra/lib/commons-lang3-3.1.jar:/usr/share cassandra/lib/commons-math3-3.2.jar:/usr/share/cassandra/lib/compress-lzf-0.8.4.jar:/usr/share/cassandra/lib/concurrentlinkedhashmap-lru-1.4.jar:/usr/share/cassandra/lib/crc32ex-0.1.1.jar:/usr/share/cassandra/lib/disruptor-3.0.1.jar:/usr/share/cassandra/lib/ecj-4.4.2.jar:/usr/share/cassandra/lib/guava-16.0.jar:/usr/share/cassandra/lib/high-scale-lib-1.0.6.jar:/usr/share/cassandra/lib/jackson-core-asl-1.9.2.jar:/usr/share/cassandra/lib/jackson-mapper-asl-1.9.2.jar:/usr/share/cassandra/lib/jamm-0.3.0.jar:/usr/share/cassandra/lib/javax.inject.jar:/usr/share/cassandra/lib/jbcrypt-0.3m.jar:/usr/share/cassandra/lib/jcl-over-slf4j-1.7.7.jar:/usr/share/cassandra/lib/jna-4.0.0.jar:/usr/share/cassandra/lib/joda-time-2.4.jar:/usr/share/cassandra/lib/json-simple-1.1.jar:/usr/share/cassandra/lib/libthrift-0.9.2.jar:/usr/share/cassandra/lib/log4j-over-slf4j-1.7.7.jar:/usr/share/cassandra/lib/logback-classic-1.1.3.jar:/usr/share/cassandra/lib/logback-core-1.1.3.jar:/usr/share/cassandra/lib/lz4-1.3.0.jar:/usr/share/cassandra/lib/metrics-core-3.1.0.jar:/usr/share/cassandra/lib/metrics-jvm-3.1.0.jar:/usr/share/cassandra/lib/metrics-logback-3.1.0.jar:/usr/share/cassandra/lib/netty-all-4.0.23.Final.jar:/usr/share/cassandra/lib/ohc-core-0.3.4.jar:/usr/share/cassandra/lib/ohc-core-j8-0.3.4.jar:/usr/share/cassandra/lib/reporter-config-base-3.0.0.jar:/usr/share/cassandra/lib/reporter-config3-3.0.0.jar:/usr/share/cassandra/lib/sigar-1.6.4.jar:/usr/share/cassandra/lib/slf4j-api-1.7.7.jar:/usr/share/cassandra/lib/snakeyaml-1.11.jar:/usr/share/cassandra/lib/snappy-java-1.1.1.7.jar:/usr/share/cassandra/lib/stream-2.5.2.jar:/usr/share/cassandra/lib/super-csv-2.1.0.jar:/usr/share/cassandra/lib/thrift-server-0.3.7.jar:/usr/share/cassandra/apache-cassandra-2.2.8.jar:/usr/share/cassandra/apache-cassandra-thrift-2.2.8.jar:/usr/share/cassandra/apache-cassandra.jar:/usr/share/cassandra/stress.jar: -XX:HeapDumpPath=/var/lib/cassandra/java_1495214268.hprof -XX:ErrorFile=/var/lib/cassandra/hs_err_1495214268.log org.apache.cassandra.service.CassandraDaemon
root@nodec40(analyticsdb):/#
root@nodec40(analyticsdb):/#
root@nodec40(analyticsdb):/# service contrail-database stop
root@nodec40(analyticsdb):/#
root@nodec40(analyticsdb):/# ps aux | grep cassandra
root 3239 0.0 0.0 8868 812 ? S+ 17:26 0:00 grep --color=auto cassandra
root@nodec40(analyticsdb):/#
root@nodec40(analyticsdb):/# contrail-status
vRouter is PRESENT

== Contrail Database ==
contrail-database: active

contrail-database-nodemgr active
kafka active

root@nodec40(analyticsdb):/# contrail-status
vRouter is PRESENT

== Contrail Database ==
contrail-database: active

contrail-database-nodemgr active
kafka active

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31903
Submitter: Megh Bhatt (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31909
Submitter: Megh Bhatt (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31903
Committed: http://github.com/Juniper/contrail-controller/commit/80d009e7a2fcc4db2c9c3a854fcff2d90e1ad483
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 80d009e7a2fcc4db2c9c3a854fcff2d90e1ad483
Author: Megh Bhatt <email address hidden>
Date: Fri May 19 16:10:27 2017 -0700

contrail-status does not show correct status for contrail-database

Seperate out initd_svc and check_return_code variables in
check_svc(). Cassandra is run as initd service even when
the init system used is upstart (ub14.04 bare metal),
supervisor (ub14.04 docker) or sysv and the service status
command always returns the correct status and so we need to
check the return code in all cases for cassandra.

Change-Id: Ibdca3f009ed46c687a949c73884c2222107629ae
Closes-Bug: #1692069

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31909
Committed: http://github.com/Juniper/contrail-controller/commit/6c4d30edf0af489d17d364ac0b149150a100be57
Submitter: Zuul (<email address hidden>)
Branch: master

commit 6c4d30edf0af489d17d364ac0b149150a100be57
Author: Megh Bhatt <email address hidden>
Date: Fri May 19 16:10:27 2017 -0700

contrail-status does not show correct status for contrail-database

Seperate out initd_svc and check_return_code variables in
check_svc(). Cassandra is run as initd service even when
the init system used is upstart (ub14.04 bare metal),
supervisor (ub14.04 docker) or sysv and the service status
command always returns the correct status and so we need to
check the return code in all cases for cassandra.

Change-Id: Ibdca3f009ed46c687a949c73884c2222107629ae
Closes-Bug: #1692069