Monasca fails libvirt detection for packstack

[Nagasai Vinaykumar Kapalavai]

Monasca-agent setup fails to enable libvirt plugin when there is no argument nova.conf in the command line. This is observed in the rdo packstack setup.

cmd = proc.as_dict(['cmdline'])['cmdline']
                if len(cmd) > 2 and 'python' in cmd[0] and 'nova-compute' in cmd[1]:
                    conf_indexes = [cmd.index(y) for y in cmd if 'nova.conf' in y]
                    if not conf_indexes:
                        if os.path.exists('/etc/nova/nova.conf'):
                            nova_conf = "/etc/nova/nova.conf"

If the nova.conf file is missing the len(cmd) is 2 and even though the default path for the nova.conf is specified, it skips the detection step. So in the condition the len(cmd) >= 2 to detect and enable libvirt plugin.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tomasz Trębski (<email address hidden>) on branch: master
Review: https://review.openstack.org/466354
Reason: Handled in another change where need to look up for config file was removed.