manila: upgrade failure from ocata to pike

[Emilien Macchi]

When deploying Manila in TripleO, the upgrade fails from Ocata to Pike when trying to create Manila shares:

Scheduler logs:
http://logs.openstack.org/00/461000/13/check/gate-tripleo-ci-centos-7-scenario004-multinode-upgrades-nv/cd90a6c/logs/subnode-2/var/log/manila/scheduler.txt.gz#_2017-05-18_14_31_45_088

Share logs:
http://logs.openstack.org/00/461000/13/check/gate-tripleo-ci-centos-7-scenario004-multinode-upgrades-nv/cd90a6c/logs/subnode-2/var/log/manila/share.txt.gz

API logs:
http://logs.openstack.org/00/461000/13/check/gate-tripleo-ci-centos-7-scenario004-multinode-upgrades-nv/cd90a6c/logs/subnode-2/var/log/manila/api.txt.gz

Ping test logs:
http://logs.openstack.org/00/461000/13/check/gate-tripleo-ci-centos-7-scenario004-multinode-upgrades-nv/cd90a6c/console.html#_2017-05-18_14_33_19_590783

[Jan Provaznik (jan-provaznik)]

It seems to be a race issue - there is missing dependency of the share on the share type resource in the pingtest template. In logs above the share type was apparently created later than share:

create share: 2017-05-18 14:31:44.293
create share type: 2017-05-18 14:31:45.236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/466217

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466217
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=28308e85b5db03c43a362561dccf2b976560724a
Submitter: Jenkins
Branch: master

commit 28308e85b5db03c43a362561dccf2b976560724a
Author: Jan Provaznik <email address hidden>
Date: Fri May 19 09:28:00 2017 +0200

    Make sure that manila share is created after share type

    The pingtest template creates both default share type and
    a share which should use this type. Explicit reference of
    the share type should assure that the share is always created
    when share type exists.

    Change-Id: I756e6a8e477de8d0e46302dda26265ae482dd2e5
    Closes-Bug: #1691853

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.