Git clone action missing arg in create plan workflow

Bug #1691740 reported by Ryan Brady
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Ryan Brady

Bug Description

jpich found a bug in testing a related patch in python-tripleoclient.

Testing the full workflow with this patch revealed a bug in the
tripleo-common part:

Git clone action expects a URL + a container name:
https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/vcs.py#L37

but the current workflow only sends a URL:
https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L106

Tags: workflows
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465937

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/465937
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=124edb0c6b47c9e56a3dda8de6ec46fa10da70ce
Submitter: Jenkins
Branch: master

commit 124edb0c6b47c9e56a3dda8de6ec46fa10da70ce
Author: Ryan Brady <email address hidden>
Date: Thu May 18 08:11:34 2017 -0400

    Fix calls to tripleo.git.clone action

    The tripleo.git.clone action expects a container and url argument.
    The workflows for creating and updating a deployment plan were
    only sending a url argument. This patch adds the container argument
    to all calls to tripleo.git.clone action.

    Change-Id: I3993fe81dfaf6ad4ad77d10d1c70c8ce29e40128
    Closes-bug: #1691740

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.1.0

This issue was fixed in the openstack/tripleo-common 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.