quickstart tries the build the wrong package if the repo name is similar

[Alex Schultz]

We hit this in the puppet-* oooq version of the jobs. The zuul_changes included puppet-watcher:

2017-05-17 20:20:59.749436 | ok: [undercloud] => {"ansible_facts": {"artg_change_list": [], "gerrit_host": "", "zuul_changes": "openstack/puppet-nova:master:refs/changes/18/465618/1^openstack/puppet-designate:master:refs/changes/04/465604/1^openstack/puppet-aodh:master:refs/changes/96/465596/1^openstack/puppet-watcher:master:refs/changes/52/465652/1^openstack/puppet-panko:master:refs/changes/41/465641/1"}, "changed": false}

but there is no puppet-watcher package. So it tried to build openstack-watcher because findpkg returned openstack-watcher

<apevec> rdopkg findpkg puppet-watcher
<apevec> name: openstack-watcher

findpkg should use -s for strict mode.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465751

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465751
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=d688b8652a68249fcc10c725622727472a5b162c
Submitter: Jenkins
Branch: master

commit d688b8652a68249fcc10c725622727472a5b162c
Author: Alex Schultz <email address hidden>
Date: Wed May 17 16:17:54 2017 -0600

    Use strict for findpkg

    We hit an issue where the change list included puppet-watcher but it
    tried to build the actual watcher package using the puppet-watcher
    versions. This resulted in failed CI runs on the puppet openstack
    modules that include oooq jobs in the gate.

    Change-Id: I7e360f2a3fb10c230ee2078cc8935e9982580731
    Closes-Bug: #1691579

[Sagi (Sergey) Shnaidman (sshnaidm)]

The patch didn't help, there is still this error:
http://logs.openstack.org/20/467620/2/gate/gate-tripleo-ci-centos-7-nonha-multinode-oooq/93cb247/console.html#_2017-05-25_10_12_58_240860

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/468041

[Alex Schultz (alex-schultz)]

So technically it did fix it because it stops building the wrong package. The issue is that quickstart attempts to build a package even if there isn't one to build. I'll create a different bug for that. the zuul_change_list isn't always what is necessary for the change as in the gate it can include other changes from the puppet openstack modules that are currently in the process to be merged (they end up in the same zuul queue)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468041
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=98e0f9f51a36da865c864d9012669d3f62df55a4
Submitter: Jenkins
Branch: master

commit 98e0f9f51a36da865c864d9012669d3f62df55a4
Author: Sagi Shnaidman <email address hidden>
Date: Thu May 25 16:53:56 2017 +0300

    Exclude puppet-watcher from building role

    When jobs run in the gate, it may include a lot of unrelated
    changes in ZUUL, for example puppet-watcher, which can not be
    built using building package role. It fails and gate job fails too

    Change-Id: I87acf6f707b43afea68a9799624e9da8d235e71f
    Related-Bug: #1691579

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.