"Use of freed value in iteration" error during adjust to zero

[Jeff Davis]

EG 2.12

During adjust to zero, we've seen occasional errors like this:

"Call to [open-ils.circ.money.billable_xact.adjust_to_zero] failed for session [...], thread trace [1]:
Use of freed value in iteration at /usr/local/share/perl/5.18.2/OpenILS/Application/Circ/CircCommon.pm line 807."

I don't have a test plan to consistently reproduce the error yet. However, the error message points to a foreach loop in the bill_payment_map_for_xact() function, in which the loop itself removes elements from the array which is being looped over. This is a problem in Perl:

http://perldoc.perl.org/perldiag.html#Use-of-freed-value-in-iteration

"You are not supposed to modify arrays while they are being iterated over. For speed and efficiency reasons, Perl internally does not do full reference-counting of iterated items, hence deleting such an item in the middle of an iteration causes Perl to see a freed value."

[Jeff Davis (jdavis-sitka)]

Branch working/user/jeffdavis/lp1691563-freed-value-in-iteration has the kind of fix that I believe is needed here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=577b0171

[Michele Morgan (mmorgan)]

We have seen this same error on a 2.12.2 system when adjusting as a result of checking in a Lost item. Setting to Confirmed.

[Mike Rylander (mrylander)]

Picked into master and 2.12. Thanks, Jeff!