#PPAPI_VERSION# not set in 10-flash script

[Mark Milburn]

Summary:
/etc/chromium-browser/customizations/10-flash sets --ppapi-flash-version to empty string.
I apologize if this is a poor description. See discussion section after "Required information" for speculation.

Required information:

1. lsb_release -rd
Description: Ubuntu 17.04
Release: 17.04

2. apt-cache policy adobe-flashplugin
adobe-flashplugin:
  Installed: 1:20170509.1-0ubuntu0.17.04.1
  Candidate: 1:20170509.1-0ubuntu0.17.04.1
  Version table:
 *** 1:20170509.1-0ubuntu0.17.04.1 500
        500 http://archive.canonical.com/ubuntu zesty/partner amd64 Packages
        100 /var/lib/dpkg/status

3. Expectation: /etc/chromium-browser/customizations/10-flash sets CHROMIUM_FLAGS with the appropriate flash version. For example:
CHROMIUM_FLAGS="$CHROMIUM_FLAGS --ppapi-flash-path=$flashso --ppapi-flash-version=25.171.0.whatever"

4. Actual result: CHROMIUM_FLAGS has flash version set to empty string.
CHROMIUM_FLAGS="$CHROMIUM_FLAGS --ppapi-flash-path=$flashso --ppapi-flash-version="

Discussion:
Ok, I'm not super familiar with Debian stuff, so I could be very very wrong. I took a peek here:

https://launchpadlibrarian.net/318983621/adobe-flashplugin_20170509.1-0ubuntu0.17.04.1.diff.gz

And I noticed that what I think is a build script fails to set #PPAPI_VERSION#. When I leave this as is, it seems to disable flash on chromium. As a workaround, I ended up doing what it looks like the build script essentially does, just within the script itself:

diff ~/stage/etc/chromium-browser/customizations/10-flash /etc/chromium-browser/customizations/10-flash
1a2
> version=$(python -c 'import sys, json; print json.load(sys.stdin)["version"]' < /usr/lib/adobe-flashplugin/manifest.json)
3c4
< CHROMIUM_FLAGS="$CHROMIUM_FLAGS --ppapi-flash-path=$flashso --ppapi-flash-version="
---
> CHROMIUM_FLAGS="$CHROMIUM_FLAGS --ppapi-flash-path=$flashso --ppapi-flash-version=$version"

Anyway, hope this is useful. Thanks for the package!

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.