Should not reset endpoint when using resource_handle

Bug #1691306 reported by Zhiyuan Cai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tricircle
Fix Released
High
Zhiyuan Cai

Bug Description

In resource_handle.NeutronResourceHandle, after connection-fail exception is caught, endpoint_url attribute is set to None and waits for client.Client to update the endpoint.

However, local plugin directly uses resource_handle to talk to central Neutron, so the endpoint_url attribute will not be updated after it's set to None. Actually, for local plugin, endpoint_url should be read from the configuration file and doesn't require updating, so it's not necessary to set it to None.

Chaoyi Huang (joehuang)
Changed in tricircle:
importance: Undecided → High
assignee: nobody → Zhiyuan Cai (luckyvega-g)
milestone: none → pike-2
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tricircle (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465475

Changed in tricircle:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tricircle (master)

Reviewed: https://review.openstack.org/465475
Committed: https://git.openstack.org/cgit/openstack/tricircle/commit/?id=4a66a4d85cc4216cc2a8582a204aa2209d5c5a9a
Submitter: Jenkins
Branch: master

commit 4a66a4d85cc4216cc2a8582a204aa2209d5c5a9a
Author: zhiyuan_cai <email address hidden>
Date: Wed May 17 17:04:18 2017 +0800

    Don't reset endpoint_url in ResourceHandle but Client

    1. What is the problem
    In resource_handle.NeutronResourceHandle, after connection-fail
    exception is caught, endpoint_url attribute is set to None and waits
    for client.Client to update the endpoint.

    However, local plugin directly uses resource_handle to talk to central
    Neutron, so the endpoint_url attribute will not be updated after it's
    set to None. Actually, for local plugin, endpoint_url should be read
    from the configuration file and doesn't require updating, so it's not
    necessary to set it to None.

    2. What is the solution for the problem
    Reset endpoint_url in Client instead of ResourceHandle

    3. What features need to be implemented to the Tricircle to
    realize the solution
    N/A

    Change-Id: If306031605f30adf933464b955386162c7f83c06
    Closes-Bug: #1691306

Changed in tricircle:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tricircle 3.3.0

This issue was fixed in the openstack/tricircle 3.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.