deploying with "--limit" will cause facts gathered twice

[Mike Chen]

When deploying with argument --limit, the first play ("Gather facts for all hosts") and second play ("Gather facts for all hosts (if using --limit)") in site.yml will both be processed, causing task "setup" gathering host facts twice, which I think is unnecessary.

link: https://github.com/openstack/kolla-ansible/blob/master/ansible/site.yml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464963

[Eduardo Gonzalez (egonzalez90)]

BTW, how you used --limit with kolla-ansible when is not a supported argument? Executing the ansible command directly?

[xxx (xxxyyyzzz-deactivatedaccount)]

Eduardo,
Actually I was not aware of the fact that --limit is not even viable with kolla-ansible. I just checked the playbook and presumed --limit is available since it was taken into account as a special case in the code.
Thanks for pointing that out.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464963
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d366dd7e4a0002a2e170dbbda1107f61807323e5
Submitter: Jenkins
Branch: master

commit d366dd7e4a0002a2e170dbbda1107f61807323e5
Author: Chen <email address hidden>
Date: Tue May 16 16:51:29 2017 +0900

    Avoid facts gathered twice when deploying with --limit

    When deploying with argument --limit, both first and second plays
    in site.yml will be processed, causing host facts gathered twice,
    which is unnecessary. Thus a condition is added to the first play
    to avoid such redundancy.

    Change-Id: I20b84c59bf73aaeca929fc56465ff2cf1cf52b8e
    Closes-Bug: #1691033

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b2 development milestone.