service load match authors

[maarts]

the service_load function in mediaitem.py match authors with _authors_match function. If the authors string includes commas like this: "Text: Mr. X, Alan Cross", the _authors_match function fails. The json.load uses by default commas for separation and split(', ') isn't a good choose...

I'am a python noob, but here the modified function:

    def _authors_match(self, song, authors):
        """
        Checks whether authors from a song in the database match the authors of the song to be imported.

        :param song: A list of authors from the song in the database
        :param authors: A string with authors from the song to be imported
        :return: True when Authors do match, else False.
        """

        author_list = []
        for author in song.authors:
            author_list.append(author.display_name)
        authors_song = ', '.join(author_list)
        if authors_song == authors:
            return True
        else:
            return False

Please fix the bug!

Thanks

[maarts (maarts)]

the chronology of song.authors may be still a problem... or switch the json separator...

[maarts (maarts)]

a little bit better...

def _authors_match(self, song, authors):

        author_list = []
        for author in song.authors:
     author_list.append(author.display_name)
            if author.display_name in authors:
                author_list.remove(author.display_name)
            else:
                return False
        # List must be empty at the end
        return not author_list

[maarts (maarts)]

now better:

def _authors_match(self, song, authors):
        author_list = []
        for author in song.authors:
            author_list.append(author.display_name)
            if author.display_name not in authors:
                return False

        authors_song = ', '.join(author_list)
        return len(authors_song) == len(authors)