DM: config annotation issues

[amit surana]

1. L3 only VN, lo0 interface has wrong subnet. Should've been 1.1.1.0/24

    /* L3 Gateway Interface, Virtual Network: dm-vn-1, UUID: 0108fd25-88bd-454e-ab8c-0e31b1aa80ed */
    unit 1014 {
        family inet {
            /* Allocated IPv4 Address from Subnet: 1.1.1.4/32 */
            address 1.1.1.4/32;
        }
    }

2. The bridge-domain annotation doesn't seem to add any additional value.

    /* Virtual Network: dm-vn-4, UUID: 423791b1-f6f0-4070-83e8-6c76d6b13f05, VRF Type: L2, Forwarding Mode: L2-L3 */
    _contrail_dm-vn-4-l2-17 {
        vtep-source-interface lo0.0;
        instance-type virtual-switch;
        vrf-import _contrail_dm-vn-4-l2-17-import;
        vrf-export _contrail_dm-vn-4-l2-17-export;
        protocols {
            evpn {
                encapsulation vxlan;
                extended-vni-list all;
            }
        }
        bridge-domains {
            /* Virtual Network: dm-vn-4, UUID: 423791b1-f6f0-4070-83e8-6c76d6b13f05, Encapsulation: VXLAN */
            bd-17 {
                vlan-id none;
                routing-interface irb.17;
                vxlan {
                    vni 17;
                }
            }
        }
    }

3. Show if VN is marked external.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31329
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31329
Committed: http://github.com/Juniper/contrail-controller/commit/ba1b75abf12d837cd72bcfa5d30b0101b0544a9e
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit ba1b75abf12d837cd72bcfa5d30b0101b0544a9e
Author: sbalineni <email address hidden>
Date: Wed May 10 10:53:28 2017 -0700

[DM]: Fixes for config annotation issues, fixes for ibgp export policy config

- Added public or private keyword for each vrf based on router_external parameter
- removed BD comment, its useless
- generated right config for lo interface subnet value
- Generated iBgp policy with inet-vpn/inet-vpn6 family types.

Change-Id: I35a24a1f49cee51709b77d3c0d2cfe4705c5112b
Closes-Bug: #1689743
Closes-Bug: #1689738

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/32641
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/32641
Committed: http://github.com/Juniper/contrail-controller/commit/ef702ac9d626397895f7c73e755d7a32cd25599e
Submitter: Zuul (<email address hidden>)
Branch: master

commit ef702ac9d626397895f7c73e755d7a32cd25599e
Author: sbalineni <email address hidden>
Date: Wed Jun 7 14:54:55 2017 -0700

[DM]: Backporting 4.0 fixes to master

- Post 4.0, DM code got re-factored, plugin model introduced.
- Manual patching was required for following fixes.

Change-Id: I6447e53c3ae824a93d227396d075ab6c75c4ac49
Closes-Bug: #1689743
Closes-Bug: #1689738
Closes-Bug: #1688752
Closes-Bug: #1691539
Closes-Bug: #1694826