Translator should use common image properties from glance

[Alvaro Lopez]

Glance defines a set of common properties to be defined on an image [1]. These include, among others "os_distro" and "os_version". If these properties are defined, Heat Translator should rely on them, instead of relying on the "distribution" and "version" properties.

[1] https://docs.openstack.org/developer/glance/common-image-properties.html

[Bob Haddleton (bob-haddleton)]

Hi @Alvaro - thanks for the bug report. I think we should add the os_distro and os_version properties and keep the existing distribution/version properties for now. We can deprecate/remove them later if no one is using them.

[Sahdev Zala (spzala)]

@Bob, thanks for taking ownership of it. I agree with the approach that it's OK to keep existing properties, doesn't hurt. I am with Alvaro at the summit :-)

[Bob Haddleton (bob-haddleton)]

Thanks @Sahdev. After looking at this code I'm wondering if we want to continue to support a defined set of versions of images? It seems like it will be impossible to keep up with the latest releases of Ubuntu/Fedora/Cirros/etc. We are already way behind, and we don't have newer images like coreOS. If there is a maintained list of "well-known" images somewhere we could try to leverage that instead of trying to keep our list up-to-dare. Thoughts? Thanks!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465788

[Sahdev Zala (spzala)]

@Bob, true. The images as we have listed were the ones that had default support in OpenStack. As you said, if we don't have to maintain it that would be good but they way we have images plus OS metadata we may not have an easy desired solution but definitely something to keep in mind. Thanks!

[Bob Haddleton (bob-haddleton)]

I took a quick look for a list of "standard" or "official" images in OpenStack but I didn't find anything. If there is such a list it would be nice to include it by reference so that when it changes we automatically pick up those changes. Otherwise we could continue with the images we have and leave out the versions so they don't get out of date as fast.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465788
Committed: https://git.openstack.org/cgit/openstack/heat-translator/commit/?id=6904aab001d754bff8ace83c53c33bebd8332531
Submitter: Jenkins
Branch: master

commit 6904aab001d754bff8ace83c53c33bebd8332531
Author: Bob.Haddleton <email address hidden>
Date: Wed May 17 21:53:36 2017 -0500

    Support os_version, os_type, and os_distro image properties

    Modified default images to use os_type, os_version and os_distro
    properties. Added logic to look for distribution/os_distro,
    type/os_type and version/os_version image properties when
    matching image properties.

    Cleaned up minor python warnings in tosca_compute.py

    Removed DOS-style newline characters from
    tosca_cluster_policies_scaling.py

    Change-Id: I72043cf4a4358cfdbc8f98238276d85dc2f5bcc0
    Closes-Bug: 1689673

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat-translator 0.9.0 release.