tripleo

The specified reference "ControllerUpgradeBatch_Step2" (in ControllerUpgradeConfig_Step0) is incorrect.

Bug #1689553 reported by Jiří Stránský on 2017-05-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Jiří Stránský	tripleo pike-2 "pike-2"

Bug Description

This breaks the O->P upgrade:

2017-05-05 20:19:50 | 2017-05-05 20:18:59Z [overcloud-AllNodesDeploySteps-fgb4tdbesv2m.AllNodesPostUpgradeSteps.ControllerDockerPuppetERROR: The specified reference "ControllerUpgradeBatch_Step2" (in ControllerUpgradeConfig_Step0) is incorrect.
2017-05-05 20:19:50 | ERROR: The specified reference "ControllerUpgradeBatch_Step2" (in ControllerUpgradeConfig_Step0) is incorrect.
2017-05-05 20:19:51 | Heat Stack update failed.

http://logs.openstack.org/61/460061/15/experimental/gate-tripleo-ci-centos-7-containers-multinode-upgrades-nv/33473dd/logs/undercloud/home/jenkins/overcloud_upgrade_console.log.txt.gz#_2017-05-05_20_19_50

This bug has been most likely introduced in change I5c8b0c4abfc0607f42fd3f2da9f5ef2702b1bbe1:

https://review.openstack.org/#/c/453238/

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-09: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/463577

Changed in tripleo:
assignee:	nobody → Jiří Stránský (jistr)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-11: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/463577
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=345150c243bc3a9bd1dd183395e7cbb0a3974a4f
Submitter: Jenkins
Branch: master

commit 345150c243bc3a9bd1dd183395e7cbb0a3974a4f
Author: Jiri Stransky <email address hidden>
Date: Tue May 9 15:48:54 2017 +0200

Make upgrade steps unconditional to fix broken dependencies

    Change I5c8b0c4abfc0607f42fd3f2da9f5ef2702b1bbe1 introduced conditions
    to optimize upgrade times and fix related bugs. Unfortunately the
    conditional inclusion would have to be paired with support in depends_on
    to work as we need. Currently we can hit this bug if the batch upgrade
    steps are undefined for some role, but upgrade steps are definied:

The specified reference "ControllerUpgradeBatch_Step2" (in
ControllerUpgradeConfig_Step0) is incorrect.

    To fix this we have to make the steps unconditional. This isn't fully
    reverting the original change because that change also addressed
    ordering issues.

Change-Id: I369591f4757c10142f5b455e64aa778e1a9a5611
Closes-Bug: #1689553