TCMU: Fix possible overwrite of t_data_sg's last iov[] and wrongly calculating base_command_size
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Ubuntu-power-systems project |
Invalid
|
Medium
|
Canonical Kernel Team | ||
linux (Ubuntu) |
Invalid
|
Medium
|
Unassigned | ||
Yakkety |
Won't Fix
|
Medium
|
Unassigned |
Bug Description
---Problem Description---
If there has BIDI data, its first iov[] will overwrite the last
iov[] for se_cmd->t_data_sg.
---uname output---
Latest Yakkety master branch
Machine Type = P8
---Steps to Reproduce---
Just have a system do workload using tcmu.
Stack trace output:
I have seen this in my environment:
(gdb) print *((tcmulib_
$7 = {iov_base = 0x3fff7c3d0000, iov_len = 8192}
(gdb) print *((tcmulib_
$3 = {iov_base = 0x3fff7c3da000, iov_len = 4096}
(gdb) print *((tcmulib_
$4 = {iov_base = 0x3fff7c3dc000, iov_len = 16384}
(gdb) print *((tcmulib_
$5 = {iov_base = 0x3fff7c3f7000, iov_len = 12288}
(gdb) print *((tcmulib_
$6 = {iov_base = 0x1306e853c0028, iov_len = 128} <--- bad pointer and length
cmu: Fix wrongly calculating of the base_command_size
https:/
tcmu: Fix possible overwrite of t_data_sg's last iov[]
https:/
tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case
https:/
This patch should also be a part of these fixes. WITH BIDI op fixes.
tags: | added: kernel-da-key |
tags: | added: ubuntu-17.04 |
Changed in ubuntu-power-systems: | |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
Changed in linux (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-power-systems: | |
status: | New → Triaged |
tags: | added: yakkety |
Changed in linux (Ubuntu Yakkety): | |
status: | New → In Progress |
Changed in linux (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubuntu-power-systems: | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
assignee: | nobody → Joseph Salisbury (jsalisbury) |
Changed in linux (Ubuntu): | |
assignee: | Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) → Joseph Salisbury (jsalisbury) |
Changed in ubuntu-power-systems: | |
importance: | Undecided → Medium |
tags: | added: triage-g |
Changed in linux (Ubuntu): | |
status: | In Progress → Invalid |
Changed in ubuntu-power-systems: | |
status: | In Progress → Invalid |
Default Comment by Bridge