Target: Fix VERIFY_16, WRITE_VERIFY, VERIFY, and WRITE_VERIFY_16

Bug #1689359 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Ubuntu-power-systems project
Invalid
Undecided
Unassigned
linux (Ubuntu)
Invalid
High
Manoj Iyer

Bug Description

---Problem Description---
List of patches that is in regards to scsi commands.

VERIFY_16 does not handle the returned CHECK_CONDITION properly resulting an in infinite loop.

Fix VERIFY and WRITE VERIFY command parsing

Use the value of the BYTCHK field to determine the size of the
Data-Out buffer. For VERIFY, honor the VRPROTECT, DPO and FUA
fields. This patch avoids that LIO complains about a mismatch
between the expected transfer length and the SCSI CDB length
if the value of the BYTCHK field is 0.

WRITE_VERIFY_16 - Large volume groups such as AIX need this command.

---uname output---
Latest Yakkety master branch

Machine Type = P8

The target is for 16.04.02 Yakkety. Below are the links to the patches that need to be backported.

target: Fix VERIFY_16 handling in sbc_parse_cdb
https://patchwork.kernel.org/patch/9643687/

target: Fix VERIFY and WRITE VERIFY command parsing
https://patchwork.kernel.org/patch/9617875/

target: Add WRITE_VERIFY_16
https://patchwork.kernel.org/patch/9686085/

bugproxy (bugproxy)
tags: added: architecture-ppc64 bugnameltc-154091 severity-critical targetmilestone-inin1610
Changed in ubuntu:
assignee: nobody → Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
affects: ubuntu → linux (Ubuntu)
bugproxy (bugproxy)
tags: added: architecture-ppc64le
removed: architecture-ppc64
Manoj Iyer (manjo)
Changed in linux (Ubuntu):
assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) → Manoj Iyer (manjo)
Revision history for this message
Manoj Iyer (manjo) wrote :

Can you please test the kernel in https://launchpad.net/~ubuntu-power-triage/+archive/ubuntu/test/ and report back here?

Changed in linux (Ubuntu):
importance: Undecided → High
status: New → Incomplete
Changed in ubuntu-power-systems:
status: New → Incomplete
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-05-10 16:16 EDT-------
Works fine

tags: added: verification-done-xenial verification-done-yakkety verification-done-zesty
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-05-11 11:34 EDT-------
https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id=69be17042db730092d25691dd85868a41d4d99ac

It looks like the target: Fix VERIFY and WRITE VERIFY command parsing patch got dropped. - Due to breaking iscsi, thus please also drop it from this too.

Manoj Iyer (manjo)
Changed in linux (Ubuntu):
status: Incomplete → Invalid
Changed in ubuntu-power-systems:
status: Incomplete → Invalid
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-05-16 10:48 EDT-------
Can a test kernel be built for the two fixes that did get merged upstream?

target: Fix VERIFY_16 handling in sbc_parse_cdb
https://patchwork.kernel.org/patch/9643687/

target: Add WRITE_VERIFY_16
https://patchwork.kernel.org/patch/9686085/

bugproxy (bugproxy)
tags: removed: verification-done-xenial verification-done-yakkety verification-done-zesty
Brad Figg (brad-figg)
tags: added: cscc
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.