enable_upgrade hiera value is no more used as the upgrade is done by ansible package update and the corresponding puppet code is no more valid. Cleanup the templates and the relevant puppet code.
Reason for this clean up:
------------------------
Having this code is making ControllerDeployment depends on UpdateDeployment. In review [1], where I am working on moving the hiera data population before the PreNetworkConfig, so that puppet code can be invoked from PreNetworkConfig.
DPDK initialize is done in puppet-vswitch. But DPDK network is created by os-net-config (NetworkDeployment). Because DPDK was initialized at later stage, dodk interface is not up. Because of which ping test fails for tenant setup and we need restart openvswitch (which is causing more issues). So we want the DPDK to be initialized before NetworkDeployment. We will invoke the puppet from the PreNetworkConfig to initialize DPDK like [2].
When I do the change [1], it is creating circular dependency between ControllerDeployment, UpdateDeployment and NetworkDeployment. Removing the unused code will remove this circular dependency. This is the reason for removal.
[1] https://review.openstack.org/#/c/430215/
[2] https://review.openstack.org/#/c/437164/3/extraconfig/pre_network/host_config_and_reboot.role.j2.yaml
Change abandoned by Saravanan KR (<email address hidden>) on branch: master
Review: https:/