RBD: Error when managing a nonexistent volume

[Michael Dovgal]

When you try to manage a nonexistent volume or one that has already
been managed (and therefore renamed on the backend), you received an
unhandled error: 'UnboundLocalError: local variable 'rbd_image'
referenced before assignment

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: Sofia Enriquez <email address hidden>
Review: https://review.fuel-infra.org/35203

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/35203
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: e0801faabc1cb98f734d755268627fc2dc341a8b
Author: Sofia Enriquez <email address hidden>
Date: Fri May 5 10:29:31 2017

RBD: Error when managing a nonexistent volume

When you try to manage a nonexistent volume or one that has already
been managed (and therefore renamed on the backend), you received an
unhandled error: 'UnboundLocalError: local variable 'rbd_image'
referenced before assignment

This patch allow the RBD driver to catch the exception and show a custom
message notifying the user.

Change-Id: I2f4d93cce3241edd6457efb1cf5a2f1dbaea2144
Closes-Bug: #1688513
(cherry picked from commit 8a06add78003320c60c8b8294c918e4a7b842049)

[Ilya Bumarskov (ibumarskov)]

Verified on 9.2 MU 2 (MOS_UBUNTU_ID = 9.0-2017-06-07-134421)

/var/log/remote/10.109.0.5/cinder-volume.log:2017-06-13T10:15:48.294364+00:00 err: 2017-06-13 10:15:48.284 11807 ERROR oslo_messaging.rpc.dispatcher [req-f0bfa054-5b5b-45ab-b548-31fdf72228ad 1fafa736f0cc47ee9cf704577efcf6f5 d21b2e281a5f4fa593bd994202a71431 - - -] Exception during message handling: Manage existing volume failed due to invalid backend reference vol_invalid: Specified rbd image does not exist.