networking-infoblox

bug in the rollback mechanism causes DNS zone delete in NIOS

Bug #1688347 reported by Akash Deep
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-infoblox
Fix Released
Undecided
Akash Deep

Bug Description

In https://github.com/openstack/networking-infoblox/blob/master/networking_infoblox/neutron/common/dns.py#L80
ib_zone returned by ibom.create_dns_zone() is always appended to the rollback_list. If the ib_zone is pre-existing, it should not be added to the rollback_list.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-infoblox (master)

Fix proposed to branch: master
Review: https://review.openstack.org/462675

Changed in networking-infoblox:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/464546

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-infoblox (master)

Change abandoned by Akash Deep (<email address hidden>) on branch: master
Review: https://review.openstack.org/462675
Reason: Fix proposed in https://review.openstack.org/#/c/464546/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-infoblox (master)

Reviewed: https://review.openstack.org/464546
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=87ee7b76725cdec20833af8effa37d42829a4930
Submitter: Jenkins
Branch: master

commit 87ee7b76725cdec20833af8effa37d42829a4930
Author: Akash Deep <email address hidden>
Date: Mon May 15 11:20:36 2017 +0530

    Fix issue in the rollback mechanism causes DNS zone delete in NIOS

    Added check to ignore rollback of objects which are pre-exist.
    Raised pull request in infoblox client:
    https://github.com/infobloxopen/infoblox-client/pull/162
    which support create_check_exist function to return object and
    obj_created flag to check if InfobloxObj is created or reused.

    Updated requirement.txt to get latest version of infoblox_client
    for which pull request is raised:
    https://github.com/infobloxopen/infoblox-client/pull/163

    Change-Id: I54bed6d64a4b03be8d238ac9556a89f65270facd
    Closes-Bug: #1688347

Changed in networking-infoblox:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-infoblox (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/466190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-infoblox (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/466191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-infoblox (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/466192

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-infoblox (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/466193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-infoblox (stable/liberty)

Reviewed: https://review.openstack.org/466193
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=e73bebc29b66e868b60d035addb7f1aacd8f465d
Submitter: Jenkins
Branch: stable/liberty

commit e73bebc29b66e868b60d035addb7f1aacd8f465d
Author: Akash Deep <email address hidden>
Date: Mon May 15 11:20:36 2017 +0530

    Fix issue in the rollback mechanism causes DNS zone delete in NIOS

    Added check to ignore rollback of objects which are pre-exist.
    Raised pull request in infoblox client:
    https://github.com/infobloxopen/infoblox-client/pull/162
    which support create_check_exist function to return object and
    obj_created flag to check if InfobloxObj is created or reused.

    Updated requirement.txt to get latest version of infoblox_client
    for which pull request is raised:
    https://github.com/infobloxopen/infoblox-client/pull/163

    Change-Id: I54bed6d64a4b03be8d238ac9556a89f65270facd
    Closes-Bug: #1688347

tags: added: in-stable-liberty
tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-infoblox (stable/mitaka)

Reviewed: https://review.openstack.org/466192
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=e6504919bf6c46e5c2e6966ded2a1af9c9c1358c
Submitter: Jenkins
Branch: stable/mitaka

commit e6504919bf6c46e5c2e6966ded2a1af9c9c1358c
Author: Akash Deep <email address hidden>
Date: Mon May 15 11:20:36 2017 +0530

    Fix issue in the rollback mechanism causes DNS zone delete in NIOS

    Added check to ignore rollback of objects which are pre-exist.
    Raised pull request in infoblox client:
    https://github.com/infobloxopen/infoblox-client/pull/162
    which support create_check_exist function to return object and
    obj_created flag to check if InfobloxObj is created or reused.

    Updated requirement.txt to get latest version of infoblox_client
    for which pull request is raised:
    https://github.com/infobloxopen/infoblox-client/pull/163

    Change-Id: I54bed6d64a4b03be8d238ac9556a89f65270facd
    Closes-Bug: #1688347

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-infoblox (stable/newton)

Reviewed: https://review.openstack.org/466191
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=9e98469f90d168e4544d3cabdc15ecd0987bcc4f
Submitter: Jenkins
Branch: stable/newton

commit 9e98469f90d168e4544d3cabdc15ecd0987bcc4f
Author: Akash Deep <email address hidden>
Date: Mon May 15 11:20:36 2017 +0530

    Fix issue in the rollback mechanism causes DNS zone delete in NIOS

    Added check to ignore rollback of objects which are pre-exist.
    Raised pull request in infoblox client:
    https://github.com/infobloxopen/infoblox-client/pull/162
    which support create_check_exist function to return object and
    obj_created flag to check if InfobloxObj is created or reused.

    Updated requirement.txt to get latest version of infoblox_client
    for which pull request is raised:
    https://github.com/infobloxopen/infoblox-client/pull/163

    Change-Id: I54bed6d64a4b03be8d238ac9556a89f65270facd
    Closes-Bug: #1688347

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-infoblox (stable/ocata)

Reviewed: https://review.openstack.org/466190
Committed: https://git.openstack.org/cgit/openstack/networking-infoblox/commit/?id=d11b425fa19fe39a0bea2d18731b16b163b0c78d
Submitter: Jenkins
Branch: stable/ocata

commit d11b425fa19fe39a0bea2d18731b16b163b0c78d
Author: Akash Deep <email address hidden>
Date: Mon May 15 11:20:36 2017 +0530

    Fix issue in the rollback mechanism causes DNS zone delete in NIOS

    Added check to ignore rollback of objects which are pre-exist.
    Raised pull request in infoblox client:
    https://github.com/infobloxopen/infoblox-client/pull/162
    which support create_check_exist function to return object and
    obj_created flag to check if InfobloxObj is created or reused.

    Updated requirement.txt to get latest version of infoblox_client
    for which pull request is raised:
    https://github.com/infobloxopen/infoblox-client/pull/163

    Change-Id: I54bed6d64a4b03be8d238ac9556a89f65270facd
    Closes-Bug: #1688347

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.