AllNodesExtraConfig should run before AllNodesDeploySteps

[Steven Hardy]

In mitaka era tripleo-heat-templates applying the post deploy steps looks like this:

  # Nested stack deployment runs after all other controller deployments
  ControllerNodesPostDeployment:
    type: OS::TripleO::ControllerPostDeployment
    depends_on: [ControllerBootstrapNodeDeployment, ControllerAllNodesDeployment, ControllerSwiftDeployment, ControllerCephDeployment]
    properties:
      servers: {get_attr: [Controller, attributes, nova_server_resource]}
      NodeConfigIdentifiers:
        allnodes_extra: {get_attr: [AllNodesExtraConfig, config_identifier]}

Note the implicit dependency on AllNodesExtraConfig - we lost that with the refactor to AllNodesDeploySteps, so some integrations that depend on writing hieradata in AllNodesExtraConfig have broken.

We should add an explicit depends_on to reinstate the original ordering, and backport it to ocata/newton I think.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/461734

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/461820

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/461821

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461734
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b8f97f5e1b36dd12c0750b83c54f17e931990a40
Submitter: Jenkins
Branch: master

commit b8f97f5e1b36dd12c0750b83c54f17e931990a40
Author: Steven Hardy <email address hidden>
Date: Tue May 2 11:54:12 2017 +0100

    Ensure AllNodesExtraConfig runs before AllNodesDeploySteps

    When implementing custom roles, we lost an implicit dependency that
    ensured AllNodesExtraConfig is applied before AllNodesDeploySteps,
    which causes problems if you need to write hieradata via the
    AllNodesExtraConfig hook (some cisco integrations we have in tree
    do this, and are now broken because the ordering is no longer ensured.

    Change-Id: Ie78ecbb4e135ab7f196867ef9d8d271049a9cd10
    Closes-Bug: #1687597

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461820
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f907ee34acdcb756b7c82c208f11fcb8678a54a9
Submitter: Jenkins
Branch: stable/ocata

commit f907ee34acdcb756b7c82c208f11fcb8678a54a9
Author: Steven Hardy <email address hidden>
Date: Tue May 2 11:54:12 2017 +0100

    Ensure AllNodesExtraConfig runs before AllNodesDeploySteps

    When implementing custom roles, we lost an implicit dependency that
    ensured AllNodesExtraConfig is applied before AllNodesDeploySteps,
    which causes problems if you need to write hieradata via the
    AllNodesExtraConfig hook (some cisco integrations we have in tree
    do this, and are now broken because the ordering is no longer ensured.

    Change-Id: Ie78ecbb4e135ab7f196867ef9d8d271049a9cd10
    Closes-Bug: #1687597
    (cherry picked from commit 4efc067a7e2965fc7a07eb05b019d0e3e8160606)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461821
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3a9da6191ade6e579484d6b99fee4401eace14cd
Submitter: Jenkins
Branch: stable/newton

commit 3a9da6191ade6e579484d6b99fee4401eace14cd
Author: Steven Hardy <email address hidden>
Date: Tue May 2 11:54:12 2017 +0100

    Ensure AllNodesExtraConfig runs before AllNodesDeploySteps

    When implementing custom roles, we lost an implicit dependency that
    ensured AllNodesExtraConfig is applied before AllNodesDeploySteps,
    which causes problems if you need to write hieradata via the
    AllNodesExtraConfig hook (some cisco integrations we have in tree
    do this, and are now broken because the ordering is no longer ensured.

    Change-Id: Ie78ecbb4e135ab7f196867ef9d8d271049a9cd10
    Closes-Bug: #1687597
    (cherry picked from commit 4efc067a7e2965fc7a07eb05b019d0e3e8160606)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/462035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462035
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=95fbda4d0254edb12bfec1ccd41d3b5f6204fe8f
Submitter: Jenkins
Branch: master

commit 95fbda4d0254edb12bfec1ccd41d3b5f6204fe8f
Author: Steven Hardy <email address hidden>
Date: Wed May 3 09:44:21 2017 +0100

    Disable ComputeNeutron* for cisco-nexus-ucsm

    It seems this wasn't adjusted when https://review.openstack.org/#/c/338315/
    landed, which added interfaces for compute specific neutron configuration,
    which is disabled for most vendor backends.

    Change-Id: I4c98008107568b3b65decd7640e25c7d2b1ea9ff
    Related-Bug: #1687597

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/464698

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/464700

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464698
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7017ba95ee6a3ae30e9c82a3d0aaa0a7030808a7
Submitter: Jenkins
Branch: stable/ocata

commit 7017ba95ee6a3ae30e9c82a3d0aaa0a7030808a7
Author: Steven Hardy <email address hidden>
Date: Wed May 3 09:44:21 2017 +0100

    Disable ComputeNeutron* for cisco-nexus-ucsm

    It seems this wasn't adjusted when https://review.openstack.org/#/c/338315/
    landed, which added interfaces for compute specific neutron configuration,
    which is disabled for most vendor backends.

    Change-Id: I4c98008107568b3b65decd7640e25c7d2b1ea9ff
    Related-Bug: #1687597
    (cherry picked from commit 95fbda4d0254edb12bfec1ccd41d3b5f6204fe8f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464700
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=db34e8e61f383e99192a0c23bb4fcf69f304d564
Submitter: Jenkins
Branch: stable/newton

commit db34e8e61f383e99192a0c23bb4fcf69f304d564
Author: Steven Hardy <email address hidden>
Date: Wed May 3 09:44:21 2017 +0100

    Disable ComputeNeutron* for cisco-nexus-ucsm

    It seems this wasn't adjusted when https://review.openstack.org/#/c/338315/
    landed, which added interfaces for compute specific neutron configuration,
    which is disabled for most vendor backends.

    Change-Id: I4c98008107568b3b65decd7640e25c7d2b1ea9ff
    Related-Bug: #1687597
    (cherry picked from commit 95fbda4d0254edb12bfec1ccd41d3b5f6204fe8f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/473945

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/474302

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/476238

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476238
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9eb4311c9d07cb14824d502904cce2dfce23cb88
Submitter: Jenkins
Branch: master

commit 9eb4311c9d07cb14824d502904cce2dfce23cb88
Author: Gonéri Le Bouder <email address hidden>
Date: Wed Jun 21 15:00:27 2017 -0400

    cisco nexus: keep OVS on the Compute

    The Cisco Nexus-UCSM environment relies on OVS for the communication
    with compute nodes. This is a partial revert of
    I4c98008107568b3b65decd7640e25c7d2b1ea9ff.

    Change-Id: I453d4bc83314a76fd779884fb2f8cd1731d2bcaa
    Related-Bug: #1687597

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/480714

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/480717

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480717
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ec87f2b3562d20735085edd17a600335540b96c8
Submitter: Jenkins
Branch: stable/ocata

commit ec87f2b3562d20735085edd17a600335540b96c8
Author: Gonéri Le Bouder <email address hidden>
Date: Wed Jun 21 15:00:27 2017 -0400

    cisco nexus: keep OVS on the Compute

    The Cisco Nexus-UCSM environment relies on OVS for the communication
    with compute nodes. This is a partial revert of
    I4c98008107568b3b65decd7640e25c7d2b1ea9ff.

    Change-Id: I453d4bc83314a76fd779884fb2f8cd1731d2bcaa
    Related-Bug: #1687597
    (cherry picked from commit 9eb4311c9d07cb14824d502904cce2dfce23cb88)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480714
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7db285feb788a6a46cdb701b246edcbd363f349c
Submitter: Jenkins
Branch: stable/newton

commit 7db285feb788a6a46cdb701b246edcbd363f349c
Author: Gonéri Le Bouder <email address hidden>
Date: Wed Jun 21 15:00:27 2017 -0400

    cisco nexus: keep OVS on the Compute

    The Cisco Nexus-UCSM environment relies on OVS for the communication
    with compute nodes. This is a partial revert of
    I4c98008107568b3b65decd7640e25c7d2b1ea9ff.

    Change-Id: I453d4bc83314a76fd779884fb2f8cd1731d2bcaa
    Related-Bug: #1687597
    (cherry picked from commit 9eb4311c9d07cb14824d502904cce2dfce23cb88)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Gonéri Le Bouder (<email address hidden>) on branch: master
Review: https://review.openstack.org/473945

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sandhya Dasu (<email address hidden>) on branch: master
Review: https://review.openstack.org/474302
Reason: Fixed via a different fix.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.1 release.