Failed to create service VM via Heat

[Sunil Basker]

The heat based service-chain test cases seem to failing while attempting to create SVM, exception is seen in API server log.

Test Setup:
Cfgm, control: nodem14
Computes: nodem8, nodem9, nodem10

Test:
attempts to create single SVM instance, in-network-firewall service chain through heat. The heat template defines the following resource port-tuple, 3 – VMIs, VM, instance-ips, SVM & SI.
Failure point seems to creation of SVM, all other resources seem to present in system. The following error is seen in api log.

Template:
https://github.com/Juniper/contrail-test-ci/blob/master/common/heat/template.py#L2245

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/__init__.py", line 1067, in handler_trap_exception
    response = handler(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_interface.py", line 482, in plugin_http_post_port
    return self.plugin_update_port(context, port)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_interface.py", line 420, in plugin_update_port
    port['resource'])
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_db.py", line 2561, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_db.py", line 3933, in port_update
    port_obj = self._port_neutron_to_vnc(port_q, None, UPDATE)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_db.py", line 1979, in _port_neutron_to_vnc
    kvps = port_bindings.get_key_value_pair()
AttributeError: 'NoneType' object has no attribute 'get_key_value_pair'

[Praneet Bachheti (praneetb)]

Fixed in this commit...

Reviewed: https://review.opencontrail.org/30818
Committed: http://github.com/Juniper/contrail-controller/commit/f2e577ab6e2ba2909c5dbea5391baa309881962e
Submitter: Zuul (<email address hidden>)
Branch: master

commit f2e577ab6e2ba2909c5dbea5391baa309881962e
Author: Sukhdev Kapur <email address hidden>
Date: Thu Apr 27 16:32:58 2017 -0700

Check to make sure portbinding value is set before acting on it

If port_binding is not set, do not bother to check for
host_id and skip the logic.

Change-Id: I1c63352e4a9a44ee7bb3ba5300107c87c98d1c8a
Closes-Bug: 1686851