No sketch mode text rendering in GAL

[Andrzej Wolski]

Text in both OpenGL and Cairo modes is always displayed in filled mode, regardless of "show in sketch mode" settings.

Version: (2017-04-21 revision 0e6723bb1)-makepkg, release build

[Jeff Young (jeyjey)]

Does this actually have much use? A curved character with lots of segments ends up half-filled in anyway. And if we move to actual fonts in the future, we won't have this option anyway.

Maybe the right way to "fix" this bug is just to remove the option?

[Andrzej Wolski (awolski)]

It may not have a lot of use, but it is nice to have.
I least I sometimes like to work in outline mode.

I don't see a reason why TrueType fonts cant be displayed in outline mode, they will look even better than stroke fonts.

I identified this problem to a fact that drawSingleLineText uses drawPolyline which draws only filled lines.
I am not sure how to properly fix this.

[Wayne Stambaugh (stambaughw)]

On 1/15/2018 11:51 AM, Andrzej Wolski wrote:
> It may not have a lot of use, but it is nice to have.
> I least I sometimes like to work in outline mode.
>
> I don't see a reason why TrueType fonts cant be displayed in outline
> mode, they will look even better than stroke fonts.

The issue is converting to TT fonts to stroke fonts for accurate output
to plot (gerber) files. This is why we don't use them in Pcbnew.

>
> I identified this problem to a fact that drawSingleLineText uses drawPolyline which draws only filled lines.
> I am not sure how to properly fix this.
>

[Jeff Young (jeyjey)]

This bug hasn't gotten any more love in 2 years, and the legacy canvas will be going away soon, so I'm going to remove the "sketch text" setting.

If we do ever move to TrueType fonts we can replace it with outline fonts.