Stabilize bgp_show_rtarget_group_test unit test

Bug #1686846 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Ananth Suryanarayana

Bug Description

This test some times crashes in ~TashScheduler() most likely because enclosing ServerThread is already deleted

diff --git a/src/bgp/test/bgp_show_rtarget_group_test.cc b/src/bgp/test/bgp_show_rtarget
index 00ba56f..5e3be10 100644
--- a/src/bgp/test/bgp_show_rtarget_group_test.cc
+++ b/src/bgp/test/bgp_show_rtarget_group_test.cc
@@ -65,6 +65,7 @@ protected:
     virtual void TearDown() {
         evm_.Shutdown();
         server_->Shutdown();
+ thread_.Join();
         task_util::WaitForIdle();
     }

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/30814
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/30814
Committed: http://github.com/Juniper/contrail-controller/commit/8a1c02cd51deaf2a9ccd2713e113a117cecaa39d
Submitter: Zuul (<email address hidden>)
Branch: master

commit 8a1c02cd51deaf2a9ccd2713e113a117cecaa39d
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Apr 27 15:04:45 2017 -0700

Stabilize bgp_show_rtarget_group_test unit test

Make sure that thread is terminated before ServerThread object
itself is destroyed

Change-Id: I42a8f07cc719feb06d35ee97b7272f5d920297b3
Closes-Bug: 1686846

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.