Health Check doesnt recover

[Hari Prasad Killi]

When HC fails and interface is deactivated, the VM is unable to get ARP resolved for the service address (the source address of the HC requests). Due to this, the VM cannot respond to the HC requests. This happens only for the last VM in the VRF.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30793
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30793
Committed: http://github.com/Juniper/contrail-vrouter/commit/d686b42e6c570a90d8356ffe91e1261e71661c9a
Submitter: Zuul (<email address hidden>)
Branch: R3.0.3.x

commit d686b42e6c570a90d8356ffe91e1261e71661c9a
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30941
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30998
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30999
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30941
Committed: http://github.com/Juniper/contrail-vrouter/commit/a1aa69339d8b7d574ae8cd3ca8742c540c6fca00
Submitter: Zuul (<email address hidden>)
Branch: R3.0

commit a1aa69339d8b7d574ae8cd3ca8742c540c6fca00
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452
(cherry picked from commit d686b42e6c570a90d8356ffe91e1261e71661c9a)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31040
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31040
Committed: http://github.com/Juniper/contrail-vrouter/commit/4430b2663cde4cb48107c04cf4d8eaec50b6b649
Submitter: Zuul (<email address hidden>)
Branch: master

commit 4430b2663cde4cb48107c04cf4d8eaec50b6b649
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30999
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30998
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/30999
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31303
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/31304
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31304
Committed: http://github.com/Juniper/contrail-vrouter/commit/92b542a0d10b2fc387dda19289e2022dc8650877
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 92b542a0d10b2fc387dda19289e2022dc8650877
Author: Anand H. Krishnan <email address hidden>
Date: Wed May 10 14:20:34 2017 +0530

Set ECMP active entry count to zero

ECMP active entry count should be set to zero when we free the
array that holds the active members.

Change-Id: I57dc6a8dab993dbc7fb156e2fbf7bcf115beebe4
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30999
Committed: http://github.com/Juniper/contrail-vrouter/commit/371ce00c0e6784f07fade5f377077027c002f657
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 371ce00c0e6784f07fade5f377077027c002f657
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/30998
Committed: http://github.com/Juniper/contrail-vrouter/commit/741e86e9c9d8c245d025d590063a87b98daf64e6
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 741e86e9c9d8c245d025d590063a87b98daf64e6
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/31303
Committed: http://github.com/Juniper/contrail-vrouter/commit/6d30c7b7e40cf866020343ec169bc06d33468e8b
Submitter: Zuul (<email address hidden>)
Branch: master

commit 6d30c7b7e40cf866020343ec169bc06d33468e8b
Author: Anand H. Krishnan <email address hidden>
Date: Wed May 10 14:20:34 2017 +0530

Set ECMP active entry count to zero

ECMP active entry count should be set to zero when we free the
array that holds the active members.

Change-Id: I57dc6a8dab993dbc7fb156e2fbf7bcf115beebe4
Closes-Bug: #1686452

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/32595
Submitter: Vinay Vithal Mahuli (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/32595
Committed: http://github.com/Juniper/contrail-vrouter/commit/9c761052a0657f66f4638d3c4fce18a61526a905
Submitter: Zuul (<email address hidden>)
Branch: R3.2.3.x

commit 9c761052a0657f66f4638d3c4fce18a61526a905
Author: Anand H. Krishnan <email address hidden>
Date: Thu Apr 27 12:12:45 2017 +0530

Reset the reach_nh pointer to original value

If the composite nexthop does not have any component nexthops,
we set the reach_nh to discard. One side effect of this behavior
is that multicast ARPs are dropped, since ARP processing happens
in the composite nexthop handling. Hence, retain the composite
nexthop functionality, even if there are no component nexthops.

As part of this change, we also make sure that if a change in
any nexthop fails, we do not disrupt the way it works.

Change-Id: Ic9ea091e3f0cbe659389bc57bea2a1e214bbd771
Closes-Bug: #1686452