Octavia v2 API Listeners don't check quota
Bug #1685789 reported by
Adam Harwell
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
octavia |
Fix Released
|
Critical
|
Adam Harwell |
Bug Description
The code just... Never made it in. I think it was supposed to be added later, but we forgot.
Changed in octavia: | |
assignee: | nobody → Adam Harwell (adam-harwell) |
status: | New → In Progress |
Changed in octavia: | |
importance: | Undecided → Critical |
Changed in octavia: | |
assignee: | Adam Harwell (adam-harwell) → Michael Johnson (johnsom) |
Changed in octavia: | |
assignee: | Michael Johnson (johnsom) → Adam Harwell (adam-harwell) |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/459032 /git.openstack. org/cgit/ openstack/ octavia/ commit/ ?id=fb0da76c277 35a965340e02ceb ff8be46271f579
Committed: https:/
Submitter: Jenkins
Branch: master
commit fb0da76c27735a9 65340e02cebff8b e46271f579
Author: Adam Harwell <email address hidden>
Date: Sat Apr 22 11:12:11 2017 +0900
Add support for single-create for APIv2
Still need to fix the entry-points for each individual type, but that
wasn't even in the original spec. Not sure if we even want that.
I think this may not do things EXACTLY how the old one did it, we'll
need to look into whether it matters, as we never published docs for it
and I don't think it ever actually worked properly in neutron-lbaas.
Also closing a few bugs that are only peripherally related, because we
(possibly me) forgot to tag them on the individual CRs, but I'm
considering them closed as of this patch. See below for my reasoning on
each individual bug, and feel free to post counter-arguments.
For #1673546 (single-call create): This is the obvious one!
For #1673499 (lb return pool object): Rolled into this patch as a matter
of course, abandoned the original fix as it is no longer relevant.
For #1544214 (root tags): All existing resources now have root tags. Any
new ones will also need root tags, but I would consider this bug closed.
For #1596636 (tenant facing API): Every object is now creatable via the
v2 API, so I would consider this to be complete. Quotas and some
additional work is being finished, but it's not necessary for this IMO.
For #1665446 (hm id): This was resolved in the HM patch, I just forgot
to close it, and including it here will ensure it is release-tracked.
For #1685789 (listener quota): Just shoving it in here as I do the
single-create quotas.
For #1685827 (hm quota): Same as listener quota.
Closes-Bug: #1673546
Closes-Bug: #1673499
Closes-Bug: #1544214
Closes-Bug: #1596636
Closes-Bug: #1665446
Closes-Bug: #1685789
Closes-Bug: #1685827
Depends-On: I3d86482a299919 7a60a81d42afc5e f7a6e71e313
Change-Id: I4ff03593e1cfd8 dca00a13c0550d6 cf95b93d746