Fuel 9.2 radosgw_keystone improperly started on controller when keystone decomposed

[Lukasz Pelczyk]

- Fuel 9.2
- Service decomposition (neutron node, keystone node, rabbitmq node)
- ceph as a storage backend

Deployment ended in error state.
Failed node: primary-controller
Manifest: /etc/puppet/modules/osnailyfacter/modular/ceph/radosgw_keystone.pp
Error:
Error: Could not prefetch keystone_service provider 'openstack': Command openstack_command is missing
Error: Not managing Keystone_service[swift] due to earlier Keystone API failures.
Error: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw]/Keystone_service[swift::object-store]/ensure: change from absent to present failed: Not managing Keystone_service[swift] due to earlier Keystone API failures.
Error: Could not prefetch keystone_endpoint provider 'openstack': Command openstack_command is missing
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw]/Keystone_endpoint[RegionOne/swift::object-store]: Dependency Keystone_service[swift::object-store] has failures: true
Warning: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw]/Keystone_endpoint[RegionOne/swift::object-store]: Skipping because of failed dependencies
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_service[swift_s3::s3]: Dependency Keystone_service[swift::object-store] has failures: true
Warning: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_service[swift_s3::s3]: Skipping because of failed dependencies
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_endpoint[RegionOne/swift_s3::s3]: Dependency Keystone_service[swift::object-store] has failures: true
Warning: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_endpoint[RegionOne/swift_s3::s3]: Skipping because of failed dependencies

Suggested fix:
Move execution of /etc/puppet/modules/osnailyfacter/modular/ceph/radosgw_keystone.pp from controller to keystone node.

When mentioned manifest was started manually on keystone I received:
root@node-43:~# puppet apply /etc/puppet/modules/osnailyfacter/modular/ceph/radosgw_keystone.pp
Notice: Scope(Class[Osnailyfacter::Ceph::Radosgw_keystone]): MODULAR: ceph/radosgw_keystone.pp
Notice: Compiled catalog for node-43.domain.tld in environment production in 0.65 seconds
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw]/Keystone_service[swift::object-store]/ensure: created
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw]/Keystone_endpoint[RegionOne/swift::object-store]/ensure: created
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_service[swift_s3::s3]/ensure: created
Notice: /Stage[main]/Osnailyfacter::Ceph::Radosgw_keystone/Keystone::Resource::Service_identity[radosgw_s3]/Keystone_endpoint[RegionOne/swift_s3::s3]/ensure: created
Notice: Finished catalog run in 10.43 seconds

Patch:
[root@fuel plugins]# cat ~/radosgw_keystone.patch
--- /etc/puppet/mitaka-9.0/modules/osnailyfacter/modular/ceph/tasks.yamlbak 2017-04-24 10:47:07.514153897 +0000
+++ /etc/puppet/mitaka-9.0/modules/osnailyfacter/modular/ceph/tasks.yaml 2017-04-24 10:45:22.101345749 +0000
@@ -104,7 +104,7 @@
 - id: radosgw-keystone
   type: puppet
   version: 2.1.0
- tags: [primary-controller]
+ tags: [primary-keystone]
   required_for: [primary-ceph-radosgw, ceph-radosgw]
   requires: [primary-keystone, keystone]
   condition:

[Michael Polenchuk (mpolenchuk)]

Need to backport properly the https://review.openstack.org/#/q/68318cf10bb7e9025fec06369a47ba54d741697a,n,z