Fill & Stroke dialog randomly stops updating colors live

Bug #168557 reported by ScislaC
4
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Jon A. Cruz

Bug Description

This was tested with current SVN (04/12/2007)

1) Open inkscape and draw a shape
2) In the fill & stroke, go into HSL, w/ full saturation w/ 50% lightness,
and drag the Hue slider back and forth a whole bunch...
3) It does live updating of the color for a while and then seems to
randomly stop doing a live update. Note that it will update on mouse
release though.

JonCruz confirmed this behavior as well.

-Josh

Tags: color ui

Related branches

Revision history for this message
Bug Importer (bug-importer) wrote :

I do not know the workings (i.e. signals etc.) of inkscape, but the
problem manifest itself in src/dialogs/fill-style.cpp:

The function
  sp_fill_style_widget_paint_dragged(...)
does a
  g_object_set_data (G_OBJECT (spw), "local", GINT_TO_POINTER (TRUE));
This is used to skip unneccessary drawing.

This "local" flag is only cleared in
  sp_fill_style_widget_update(...)
with
  g_object_set_data (G_OBJECT (spw), "local", GINT_TO_POINTER (FALSE));

At first, dragging the slider slowly everything is fine. Increasing the
slider dragging speed seems to trigger the bug and
sp_fill_style_widget_update() does not get called anymore until the mouse
button is released. The use of "local" seems to work for a while,
preventing unneccessary updates, but when sp_fill_style_widget_update()
ceases somehow to get called, "local" is not reset and no update to the
color is made.

Removing the effect of "local" (i.e, removing the return) in
sp_fill_style_widget_paint_dragged() is not the solution (the widget shows
a lag when dragged then), but the color of the object is updated all the
time.

I think that the real problem is happening somewhere before this when the
signals are generated.

Ryan Lerch (ryanlerch)
Changed in inkscape:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
choff (saperlipopette) wrote :

In the following attachment (poster.svg - never mind the missing images) there are two boxes with rounded corners. If I open the color dialoge (shift-ctrl-f) and try to change the color of the stroke paint, nothing happens however hard I fumble around. If I draw a new box, it works as expected - colors update and show the colors in the dialogue.
I think this is a rather severe bug. Thought maybe you can use this attachment for troubleshooting?

Revision history for this message
Pablo Trabajos (pajarico) wrote :

I can confirm that the bug reported by Josh is still present in 17586. In sliders it happens exactly as he described it. Both on the color wheel and sliders.

su_v (suv-lp)
tags: added: color ui
Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

Fixed in revision #9258.

Changed in inkscape:
assignee: nobody → Jon A. Cruz (jon-joncruz)
status: Confirmed → In Progress
status: In Progress → Fix Committed
milestone: none → 0.48
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.