Internal Flag ingest.disable_metabib_field_entry not used

[Jason Stephenson]

Evergreen Versions 2.10 - 2.12 (probably affects earlier versions)
OpenSRF Version: N/A
PostgreSQL Version: N/A

While working on yet-another-ingest script, I noticed that the config.internal_flag ingest.disable_metabib_field_entry is not used in the biblio.indexing_ingest_or_delete function.

It looks like it should be checked before the line that does:

PERFORM metabib.reingest_metabib_field_entries(NEW.id);

If the consensus is that the setting should be checked before performing that operation, I can make a patch branch rather easily.

[Jason Stephenson (jstephenson)]

Following some discussion in IRC http://irc.evergreen-ils.org/evergreen/2017-04-21#i_301342

The ingest.disable_metabib_field_entry flag is apparently obsoleted by the three flags controlling search, browse, and facet indexing.

I'll make a branch to remove the flag from the table and share it shortly.

[Jason Stephenson (jstephenson)]

Branch with pgtap test pushed to working/user/dyrcona/lp1684984-remove-ingest.disable_metabib_field_entry

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1684984-remove-ingest.disable_metabib_field_entry

Not sure if this needs a release note or not.

[Jason Stephenson (jstephenson)]

I added a release note in a second commit. Feel free to squash it into the previous commit if that makes review/pushing easier.

[Galen Charlton (gmc)]

Tested and signed off. Branch is user/gmcharlt/lp1684984_signoff.

[Galen Charlton (gmc)]

Pushed to master. Thanks, Jason!

[Ben Shum (bshum)]

assigning to correct milestone