devmode with GERRIT fails due to protocol field removed from git task

[Mike Bayer]

Using devmode with a Gerrit host fails due to the change in https://review.openstack.org/#/c/449951/. The "https://" prefix is now part of the URL that's expected by the git task in roles/build-test-packages/tasks/dlrn-build.yml, however this prefix is not provided when using the roles/build-test-packages/library/jenkins_deps.py task with GERRIT_HOST:

TASK [build-test-packages : Clone the gated change] ****************************
task path: /home/classic/.quickstart/usr/local/share/ansible/roles/build-test-packages/tasks/dlrn-build.yml:54
Wednesday 19 April 2017 16:42:24 -0400 (0:00:00.093) 0:07:24.595 *******
fatal: [hab-11.ha.lab.eng.bos.redhat.com]: FAILED! => {"changed": false, "cmd": "/usr/bin/git clone --origin origin review.openstack.org/openstack/puppet-tripleo /home/stack/DLRN/data/puppet-tripleo", "failed": true, "msg": "fatal: repository 'review.openstack.org/openstack/puppet-tripleo' does not exist", "rc": 128, "stderr": "fatal: repository 'review.openstack.org/openstack/puppet-tripleo' does not exist\n", "stdout": "", "stdout_lines": []}

There's no workaround, since adding https:// to GERRIT_HOST also fails because the get_details() function prepends https:// and also the check against ALLOWED_HOSTS assumes a plain hostname.

The gerrit at https://review.openstack.org/#/c/458153/ provides a fix for this issue.

[Attila Darazs (adarazs)]

I missed this bug report and the consecutive fix for it, and I fixed this bug at https://bugs.launchpad.net/tripleo/+bug/1690899 where it was recently reported.

Sorry for not using your change, it was really nicely done.

Attila

[Mike Bayer (zzzeek)]

alirghty ill abandon mine, if it's fixed it's fixed!

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Bayer (<email address hidden>) on branch: master
Review: https://review.openstack.org/458153
Reason: already fixed by https://review.openstack.org/#/c/465025/