[Nova] ComputeCapacityFilter always reject irrelevant,self-defined specs

[Michael Kraynov]

Please backport the following upstream bug https://bugs.launchpad.net/nova/+bug/1582589

When I enabe ComputeCapacityFilter:
If I define a irrelevant specs in flavor like key='x' value='y'
ComputeCapacityFilter will return flase,I can't create instances.

If I define a irrelevant specs like key='mykey:x' value='y'
ComputeCapacityFilter will return True

This means if I don't add a head string and a colon before my real key, ComputeCapacityFilter doesn't permit me to use it.

If this kind of specs is not allowed,I believe this should be refused in horizon or api,not in filter.

But when i read test_compute_capabilities_filters.py, I find it is permitted,but only for ComputeCapacityFilter's specs.

code:
    def test_compute_filter_pass_extra_specs_same_as_scope(self):
        # Make sure this still works even if the key is the same as the scope
        self._do_test_compute_filter_extra_specs(
            ecaps={'capabilities': 1},
            especs={'capabilities': '1'},
            passes=True)

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: stable/mitaka
Change author: yufei zhang <[e-mail]>
Review: https://review.fuel-infra.org/34468

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0/mitaka
Change author: yufei zhang <[e-mail]>
Review: https://review.fuel-infra.org/34469

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Roman Podoliaka <email address hidden> on branch: stable/mitaka
Review: https://review.fuel-infra.org/34468
Reason: oops, wrong branch

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/34469
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: 59541cfc65d80f638342fc4441a5b6dc00aaaf75
Author: yufei zhang <[e-mail]>
Date: Mon Apr 24 10:35:33 2017

Allow irrelevant,self-defined specs in ComputeCapacityFilter

For backward compatibility, ComputeCapacityFilter treats extra spec
keys which contain no colons like 'x' the same as 'capabilities:x',
because hoststate doesn't contain attribute like x, this filter always
return False. So it causes conflict with
AggregateInstanceExtraSpecsFilter, and limits user to define extra spec
keys without colons.

This patch solves the conflict and keep it backward compatible.

This patch also joins two lines into one in method host_passes.

Closes-Bug: #1683748

Change-Id: Ia9e7c882bcee131e106e67dc46ed9ce1224e4c67

[Ilya Bumarskov (ibumarskov)]

Verified on 9.2 MU 2 (MOS_UBUNTU_ID = 9.0-2017-06-07-134421)

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: mcp/1.0/mitaka
Change author: yufei zhang <[e-mail]>
Review: https://review.fuel-infra.org/36363

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Vladyslav Drok <email address hidden> on branch: mcp/1.0/mitaka
Review: https://review.fuel-infra.org/36363

[Fuel Devops McRobotson (fuel-devops-robot)]

Change restored by Vladyslav Drok <email address hidden> on branch: mcp/1.0/mitaka
Review: https://review.fuel-infra.org/36363

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/36363
Submitter: Pkgs Jenkins <email address hidden>
Branch: mcp/1.0/mitaka

Commit: 4527f3697b511091ee3f00afe5a7dd6f4b0df496
Author: yufei zhang <[e-mail]>
Date: Thu Aug 31 17:38:34 2017

Allow irrelevant,self-defined specs in ComputeCapacityFilter

For backward compatibility, ComputeCapacityFilter treats extra spec
keys which contain no colons like 'x' the same as 'capabilities:x',
because hoststate doesn't contain attribute like x, this filter always
return False. So it causes conflict with
AggregateInstanceExtraSpecsFilter, and limits user to define extra spec
keys without colons.

This patch solves the conflict and keep it backward compatible.

This patch also joins two lines into one in method host_passes.

PROD ticket: https://mirantis.jira.com/browse/PROD-14347

Closes-Bug: #1683748

Change-Id: Ia9e7c882bcee131e106e67dc46ed9ce1224e4c67