web client: Scanning non-existent items at item status fails without feedback to the user

[Kathy Lussier]

Evergreen version: master as of 4/17. This feature works as expected in 2.12.

As previously reported by Jason Etheridge in bug 1528924, with the addition of the code from that bug, we no longer get an alert when scanning a non-existent barcode in the item status screen. Expected behavior is to receive an alert that says the copy is mis-scanned or is not cataloged.

Marking as confirmed since Jason originally reported the bug and I've replicated the problem.

[Andrea Neiman (aneiman)]

Kathy -- do you mean scanning in item status? Bug 1528924 is referring to item status, and indeed, I see this bug in item status but not in check in.

[Kathy Lussier (klussier)]

Ugh, yeah. I'll update the description. Thanks Andrea!

[Jennifer Pringle (jpringle-u)]

When I scan a non-existent barcode into Item Status on 2.12.1. I get a a big red "Item Not Found" across the screen and I hear the da da noise (not sure how else to describe it) so the user is getting some feedback now. Are we still wanting the red alert/submarine siren and the "XXX was either mis-scanned or is not catalogued" message as well?

[Kathy Lussier (klussier)]

Hi Jennifer,

This bug only occurs in master. It's a regression caused by code that added column picker options in Item Status, which was never backported to 2.12. I'll update the original description to make it clear where the problem is occurring.

As a sidenote, if we cannot get a fix for this by the 3.0 release, we should probably discuss whether we want to revert the code that added the column picker options. It's very important to have those options, but one might argue that failed scans without feedback are more of a problem.

[Cesar V (cesardv)]

Just FYI I have a patch/fix for this but it's based on a branch that has yet to hit master (see comment # on bug 1685929)... so in an effort to reduce conflicts and extra merge work for whomever gets to merge that, it should wait until that branch hits master.

Branch link to follow.

[Cesar V (cesardv)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1683575-webstaff_itemStatus_bad_barcode_alert

[Galen Charlton (gmc)]

Tested and pushed to master. Thanks, Cesar!