BEFORE and AFTER events called in bulk transactions

Bug #1683550 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Kevin Benton

Bug Description

Bulk network creation ends up calling BEFORE and AFTER events while in an enclosing transaction. This violates the callback event semantics and leads to traces like http://logs.openstack.org/78/385178/20/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ba7dfb9/logs/screen-q-svc.txt.gz?level=TRACE#_2017-04-17_07_48_36_708 that indicate that a result couldn't be retrieved from the DB in a separate transaction because it's not committed.

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/457423

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/457423
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=47fdee443680c04a85d741a2f7efd31df4bfcff5
Submitter: Jenkins
Branch: master

commit 47fdee443680c04a85d741a2f7efd31df4bfcff5
Author: Kevin Benton <email address hidden>
Date: Mon Apr 17 18:46:49 2017 -0700

    Fixup event transaction semantics for ML2 bulk ops

    This splits out code in ML2 for ports, subnets, and networks
    into clear before, during, and after functions corresponding
    to the state of the transaction they are called within.
    This allows the bulk creation to correctly call chunks of code
    outside of DB transactions even when doing many creations at once.

    Change-Id: Id6fe0f5066358be954a6ca14dd49c36755897e31
    Closes-Bug: #1683550

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

tags: added: neutron-proactive-backport-potential
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

That's a change in transaction semantics that is unsafe to backport for Ocata.

tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.