barbican_crypto_password is missing in passwords.yml file

[Jeffrey Zhang]

barbican_crypto_password need to be added into passwords.yml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/457117

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/457117
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fb9ab70e6f7dddbbfaa36a34babfc2273efa1fd6
Submitter: Jenkins
Branch: master

commit fb9ab70e6f7dddbbfaa36a34babfc2273efa1fd6
Author: Jeffrey Zhang <email address hidden>
Date: Mon Apr 17 10:27:39 2017 +0800

    Add barbican_crypto_password key in passwords.yml file

    Change-Id: Ib966858f0422521e8896404ad458ea23143083e0
    Closes-Bug: #1683216

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/457141
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=4f3697f3cbd918a99347a23f68b83f65244b19db
Submitter: Jenkins
Branch: stable/ocata

commit 4f3697f3cbd918a99347a23f68b83f65244b19db
Author: Jeffrey Zhang <email address hidden>
Date: Mon Apr 17 10:27:39 2017 +0800

    Add barbican_crypto_password key in passwords.yml file

    Change-Id: Ib966858f0422521e8896404ad458ea23143083e0
    Closes-Bug: #1683216
    (cherry picked from commit fb9ab70e6f7dddbbfaa36a34babfc2273efa1fd6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 4.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b2 development milestone.

[Mark Goddard (mgoddard)]

Related bug: https://bugs.launchpad.net/kolla-ansible/+bug/1699476

I think that barbican_crypto_password was actually a typo and should have been barbican_crypto_key.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476090
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=2e4359069e8a50f83fe0dca1103d935212dd2703
Submitter: Jenkins
Branch: master

commit 2e4359069e8a50f83fe0dca1103d935212dd2703
Author: Mark Goddard <email address hidden>
Date: Wed Jun 21 11:53:14 2017 +0100

    Barbican simple_crypto plugin broken - invalid key

    When using the simple_crypto plugin, barbican expects the
    [simple_crypto_plugin] kek config value to be a base64-encoded 32 byte
    value. However, kolla-ansible is providing a standard autogenerated
    password.

    There are two relevant variables in kolla-ansible -
    barbican_crypto_password (a standard password) and barbican_crypto_key
    (a HMAC-SHA256 key). There is no use of barbican_crypto_key other than
    when it is generated. barbican_crypto_password is used to set the
    [simple_crypto_plugin] kek config value but causes an error when the
    simple_crypto plugin is used as the value is not in the expected format.
    Using barbican_crypto_key instead resolves the error. Clearly there is a
    naming issue here and we should be using barbican_crypto_key instead of
    barbican_crypto_password.

    This change removes the barbican_crypto_password variable and uses
    barbican_crypto_key instead.

    Change-Id: I63e2b381c260265e5901ee88ca0a649d96952bda
    Closes-Bug: #1699014
    Related-Bug: #1683216
    Co-Authored-By: Stig Telfer <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/491251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491251
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=24b49ed83eb232f43de5a455a83f35f4cd67e443
Submitter: Zuul
Branch: stable/ocata

commit 24b49ed83eb232f43de5a455a83f35f4cd67e443
Author: Mark Goddard <email address hidden>
Date: Wed Jun 21 11:53:14 2017 +0100

    Barbican simple_crypto plugin broken - invalid key

    When using the simple_crypto plugin, barbican expects the
    [simple_crypto_plugin] kek config value to be a base64-encoded 32 byte
    value. However, kolla-ansible is providing a standard autogenerated
    password.

    There are two relevant variables in kolla-ansible -
    barbican_crypto_password (a standard password) and barbican_crypto_key
    (a HMAC-SHA256 key). There is no use of barbican_crypto_key other than
    when it is generated. barbican_crypto_password is used to set the
    [simple_crypto_plugin] kek config value but causes an error when the
    simple_crypto plugin is used as the value is not in the expected format.
    Using barbican_crypto_key instead resolves the error. Clearly there is a
    naming issue here and we should be using barbican_crypto_key instead of
    barbican_crypto_password.

    This change removes the barbican_crypto_password variable and uses
    barbican_crypto_key instead.

    Change-Id: I63e2b381c260265e5901ee88ca0a649d96952bda
    Closes-Bug: #1699014
    Related-Bug: #1683216
    Co-Authored-By: Stig Telfer <email address hidden>
    (cherry picked from commit 2e4359069e8a50f83fe0dca1103d935212dd2703)