reloop_exit and reloop_toggle mixxx controls

[Wihola IT]

May be this #1088117 and this #1088256 bugs are related.

I have today's build from GitHub, and `𝐫𝐞𝐥𝐨𝐨𝐩_𝐭𝐨𝐠𝐠𝐥𝐞` doesn't do anything. Doesn't toggle the loop. Instead this is done by `𝐫𝐞𝐥𝐨𝐨𝐩_𝐞𝐱𝐢𝐭`. On the WIKI said, that `𝐫𝐞𝐥𝐨𝐨𝐩_𝐞𝐱𝐢𝐭` is deprecated.

I agree, that `𝐫𝐞𝐥𝐨𝐨𝐩_𝐞𝐱𝐢𝐭` sounds misleading, and `𝐫𝐞𝐥𝐨𝐨𝐩_𝐭𝐨𝐠𝐠𝐥𝐞` is better.

Also I have weird behavior of the 'loop' skin icon, when I do
𝐞𝐧𝐠𝐢𝐧𝐞.𝐜𝐨𝐧𝐧𝐞𝐜𝐭𝐂𝐨𝐧𝐭𝐫𝐨𝐥('[𝐂𝐡𝐚𝐧𝐧𝐞𝐥𝟏]', '𝐫𝐞𝐥𝐨𝐨𝐩_𝐞𝐱𝐢𝐭', '𝐂𝐨𝐧𝐭𝐫𝐨𝐥𝐥𝐞𝐫.𝐥𝐨𝐨𝐩𝐋𝐄𝐃'); //reloop_toggle have the same affect

While hot cues works fine, and skin totally corresponds to the controller's lights, loop icon are lighted in the skin, but doesn't light the controller's LED, only does it when I point and hold LMB. When release the mouse, controller's LED becomes dark. I am waiting that it should be lighted up, when loop is active.

Deree and LateNight skins.

Can anybody confirm that?

[Daniel Schürmann (daschuer)]

reloop_toggle will be work after https://github.com/mixxxdj/mixxx/pull/1187 is merged.

The controller LED should work as desired if it is correct mapped.
Maybe there is a bug in the controller mapping. Which controller do you have?

[Wihola IT (wihola)]

I have CMD PL-1. Didn't have such issues for other buttons and rotaries. I am doing: 𝐞𝐧𝐠𝐢𝐧𝐞.𝐜𝐨𝐧𝐧𝐞𝐜𝐭𝐂𝐨𝐧𝐭𝐫𝐨𝐥('[𝐂𝐡𝐚𝐧𝐧𝐞𝐥𝟏]','𝐫𝐞𝐥𝐨𝐨𝐩_𝐭𝐨𝐠𝐠𝐥𝐞','𝐌𝐲𝐂𝐨𝐧𝐭𝐫𝐨𝐥𝐥𝐞𝐫.𝐥𝐨𝐨𝐩𝐋𝐄𝐃'); //I tried `reloop_exit` too

𝐌𝐲𝐂𝐨𝐧𝐭𝐫𝐨𝐥𝐥𝐞𝐫.𝐥𝐨𝐨𝐩𝐋𝐄𝐃 = 𝐟𝐮𝐧𝐜𝐭𝐢𝐨𝐧 (𝐯𝐚𝐥𝐮𝐞, 𝐠𝐫𝐨𝐮𝐩, 𝐜𝐨𝐧𝐭𝐫𝐨𝐥) {
    𝐦𝐢𝐝𝐢.𝐬𝐞𝐧𝐝𝐒𝐡𝐨𝐫𝐭𝐌𝐬𝐠(𝟎𝐱𝟗𝟎, 𝟎𝐱𝟏𝟒, 𝐯𝐚𝐥𝐮𝐞);
}

The light is on only when I press the loop button. When I release it, light disappear. In the skin it stay lighted though.

[Be (be.ing)]

Use the loop_enabled ControlObject to light the LED on your controller.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8845