PEP8 is failing for networking-vsphere master branch because of syntax change in python3

Bug #1682353 reported by Aman Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-vsphere
Fix Released
Undecided
Aman Kumar

Bug Description

2017-04-11 13:00:39.897008 | pep8 runtests: PYTHONHASHSEED='3658768658'
2017-04-11 13:00:39.897048 | pep8 runtests: commands[0] | flake8
2017-04-11 13:00:39.898290 | /home/jenkins/workspace/gate-networking-vsphere-pep8-ubuntu-xenial$ /home/jenkins/workspace/gate-networking-vsphere-pep8-ubuntu-xenial/.tox/pep8/bin/flake8
2017-04-11 13:00:46.461177 | ./networking_vsphere/agent/ovsvapp_agent.py:1755:16: F821 undefined name 'cmp'
2017-04-11 13:00:46.461310 | if cmp(old_port_object.admin_state_up,
2017-04-11 13:00:46.461347 | ^
2017-04-11 13:00:48.211565 | ./networking_vsphere/tests/unit/neutronclient/test_cli20.py:1:77: H903 Windows style line endings not allowed in code
2017-04-11 13:00:48.211719 | # Licensed under the Apache License, Version 2.0 (the "License"); you may
2017-04-11 13:00:48.211785 | ^
2017-04-11 13:00:48.211864 | ./networking_vsphere/tests/unit/neutronclient/test_cli20.py:2:77: H903 Windows style line endings not allowed in code
2017-04-11 13:00:48.211924 | # not use this file except in compliance with the License. You may obtain
2017-04-11 13:00:48.211983 | ^
2017-04-11 13:00:48.539039 | ./networking_vsphere/tests/unit/nova/virt/vmwareapi/test_ovsvapp_vc_driver.py:263:19: F821 undefined name 'long'
2017-04-11 13:00:48.539179 | mem_kib = long(self.type_data['memory_mb']) << 10
2017-04-11 13:00:48.539210 | ^
2017-04-11 13:00:48.539281 | ./networking_vsphere/tests/unit/nova/virt/vmwareapi/test_ovsvapp_vc_driver.py:308:19: F821 undefined name 'long'
2017-04-11 13:00:48.539326 | mem_kib = long(self.type_data['memory_mb']) << 10
2017-04-11 13:00:48.539354 | ^
2017-04-11 13:00:50.385077 | ./networking_vsphere/tests/unit/utils/test_dvs_util.py:87:50: E901 SyntaxError: invalid syntax
2017-04-11 13:00:50.385243 | 'port_range_max': 22L,
2017-04-11 13:00:50.385293 | ^
2017-04-11 13:00:54.809744 | ERROR: InvocationError: '/home/jenkins/workspace/gate-networking-vsphere-pep8-ubuntu-xenial/.tox/pep8/bin/flake8'

Aman Kumar (amank)
Changed in networking-vsphere:
assignee: nobody → Aman Kumar (amank)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-vsphere (master)

Fix proposed to branch: master
Review: https://review.openstack.org/456530

Aman Kumar (amank)
Changed in networking-vsphere:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-vsphere (master)

Reviewed: https://review.openstack.org/456530
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=b5839d06bec4cc0f529e74ed6228a71c96abeac9
Submitter: Jenkins
Branch: master

commit b5839d06bec4cc0f529e74ed6228a71c96abeac9
Author: Aman Kumar <email address hidden>
Date: Fri Mar 24 08:24:54 2017 -0700

    Resolve the pep8 failure with multiple issue

    1. cmp(a,b) is removed from python3
    2. H903 Windows style is used: Changed the windows style to linux style
    3. long is removed in python3, changed the long to int

    Change-Id: I85e023ebaac9e09563f0156eb9390e2054eb4fac
    Colses-Bug: #1682353

Changed in networking-vsphere:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.