Juniper Openstack

Add more unit test to bgp_show_route.cc

Bug #1681953 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Unassigned
Juniper Openstack r4.0.0.0-fcs "r4.0.0.0"

Bug Description

In parricular, bool ShowRouteHandler::ConvertReqIterateToReq() is not tested by any of the current unit tests

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/30333
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/30333
Committed: http://github.org/Juniper/contrail-controller/commit/1abc3a004ee909aa22ecc8285f99ecdfa7005271
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1abc3a004ee909aa22ecc8285f99ecdfa7005271
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Apr 11 13:21:25 2017 -0700

Add specific unit to test ShowRouteHandler::ConvertReqIterateToReq()

code-coverage indicated clearly that all of the code in this routine is untested
Added a specific test to cover the same. Line coverage for bgp_show_route.c
increased from 72.5% to ~90% with this additional unit test.

Move ShowRouteHandler class definition to a new file and fix a few nits there by
found by cpplint

Closes-Bug: 1681953
Change-Id: I269cd426fe19e4f99a33e2fa1a60f0bca22635d9

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.