webstaff: crash when attempting to open opt-in confirmation modal

[Galen Charlton]

When performing a patron barcode search in the web staff client and opt-in is required, the dialog that is supposed to confirm whether the patron is permitting opting in to the foreign fails to load with the following error:

angular.js:14199 TypeError: Cannot read property 'length' of undefined
    at k (angular.js:12592)
    at new service.open.$uibModal.open.controller (ui.js:254)
    at Object.invoke (angular.js:4771)
    at R.instance (angular.js:10592)
    at ui-bootstrap-tpls.min.js:8
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

The immediate cause is that the egCore.strings.OPT_IN_DIALOG string around line 800 of circ/patron/app.js is not defined anywhere.

Evergreen 2.12+

[Jeff Davis (jdavis-sitka)]

Pushed a fix to working/user/jeffdavis/lp1681466-opt-in-dialog:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=c19f36c3

[Galen Charlton (gmc)]

Thanks, Jeff! I've signed off on your patch and added a followup that adds test instructions as well as a title for the dialog. The signoff branch is user/gmcharlt/lp1681466_signoff.

[Bill Erickson (berick)]

Confirmed, tested, and merged to master/rel_2_12. Thanks Jeff, thanks Galen.