Volume related quota exceptions not handled while creating vms

[Abhishek Sharma M]

VM creation may fail if it fails to meet these 3 volume related quotas.
1. per_volume_gigabytes - maximum size in GB per volume
2. gigabytes - total GB used across all volumes in a project
3. volumes - maximum number of volumes per project

When any vm creation fails because of exceeding the above quota, the error message is not specific to which quota failed. A generic error message is generated which says "Failure prepping block device".

We need to handle this scenario & generate problem related error message.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/455118

[John Garbutt (johngarbutt)]

Please could we get the log you are seeing relating to this bit of the code:
https://github.com/openstack/nova/blob/3092d2adcb6bab0bf39b01ea0561ec7e6a3990fd/nova/compute/manager.py#L2111

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/460293

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/460305

[OpenStack Infra (hudson-openstack)]

Change abandoned by Abhishek Sharma M (<email address hidden>) on branch: master
Review: https://review.openstack.org/455118
Reason: I have added fresh changes (https://review.openstack.org/#/c/460305/1) to resolve https://bugs.launchpad.net/nova/+bug/1680457. SO I am abandoning this change set.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Abhishek Sharma M (<email address hidden>) on branch: master
Review: https://review.openstack.org/460293
Reason: Fixed as part of https://review.openstack.org/#/c/460305/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460305
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=510371d526bd45195be806fb153646abdc269b70
Submitter: Jenkins
Branch: master

commit 510371d526bd45195be806fb153646abdc269b70
Author: Abhishek Sharma <email address hidden>
Date: Wed Apr 26 16:38:15 2017 -0400

    Catching OverQuota Exception

    When any vm creation fails because of exceeding 'gigabytes',
    'volumes', 'per_volume_gigabytes' quotas, the error message
    generated is specific to 'volumes' quota which says
    "Volume resource quota exceeded". Instead, the error message
    should be specific to the quota which failed.

    Change-Id: I9c1ac2cd4752d5aac20d06407792647b4549ad3d
    Closes-Bug: 1680457

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/462561

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462561
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f5a17d9ed312509e51fea154a17c4c5fe118c66b
Submitter: Jenkins
Branch: stable/ocata

commit f5a17d9ed312509e51fea154a17c4c5fe118c66b
Author: Abhishek Sharma <email address hidden>
Date: Wed Apr 26 16:38:15 2017 -0400

    Catching OverQuota Exception

    When any vm creation fails because of exceeding 'gigabytes',
    'volumes', 'per_volume_gigabytes' quotas, the error message
    generated is specific to 'volumes' quota which says
    "Volume resource quota exceeded". Instead, the error message
    should be specific to the quota which failed.

    Change-Id: I9c1ac2cd4752d5aac20d06407792647b4549ad3d
    Closes-Bug: 1680457
    (cherry picked from commit 510371d526bd45195be806fb153646abdc269b70)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.