NullReferenceException when setting MSTS installation path

[Tejesember]

Steps to reproduce:
I made a clean install with the 1.2 installer
It pops up the Options Content page, and when I chose the path of MSTS, press OK, this arises:

System.NullReferenceException: Object reference not set to an instance of an object.
   at ORTS.OptionsForm.buttonContentBrowse_Click(Object sender, EventArgs e) in e:\Documents\Coding\Jenkins\jobs\Open Rails Unstable\workspace\Source\Menu\Options.cs:line 650
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

This happens with instable channel, and locally built SVN r3822 as well.
Looks like ORTS.OptionsForm.bindingSourceContent.Current is null or not ContentFolder.

[Tejesember (tejes)]

I've got some time to further investigate the problem, and I created a patch fixing it too.

The bug occurred only when OR could not find the MSTS path in the registry, and there was no content folder added either. The datagrid is therefore empty, but the browse button is not disabled, its event handler tries to access the current selection in the datagrid upon selecting something, but it is null.
My solution is pretty straightforward, check for entries in the OptionsForm constructor and disable the browse button and name textfield if necessary. Also added a null check in the folder browser's event handler, just in case.

[Derek Morton (derek-a)]

no feedback