Horizon ignores external theme templates

Bug #1680265 reported by Gary W. Smith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Gary W. Smith

Bug Description

When a custom theme resides outside of the openstack_dashboard directory tree, horizon silently ignores all html template files contained within. This bug was introduced by the fix for bug 1582298, which altered the Theme Template loader.

Changed in horizon:
assignee: nobody → Gary W. Smith (gary-w-smith)
Changed in horizon:
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I think this potentially breaks existing deployments, so set the priority to High.

Changed in horizon:
importance: Undecided → High
milestone: none → pike-1
Changed in horizon:
milestone: pike-1 → pike-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/453919
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d5306eccf4ec17b523ae6832608a00edf3755b43
Submitter: Jenkins
Branch: master

commit d5306eccf4ec17b523ae6832608a00edf3755b43
Author: Gary Smith <email address hidden>
Date: Wed Apr 5 15:19:55 2017 -0700

    Restore the ability to load external templates

    Change the Theme Template loader to not absolutely require that
    templates reside under the Django directory (openstack_dashboard), by
    deferring the usage of safe_join to the point where that check is
    made and handled correctly.

    Also addressed on Pythonic nit noted in the review of
    https://review.openstack.org/317051

    Closes-Bug: #1680265
    Change-Id: Icf86df5e213d47b207e99b721e9e0fcdc898882e

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b2

This issue was fixed in the openstack/horizon 12.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.