dmitest output needs to be improved
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
Medium
|
Jeff Lane |
Bug Description
The current output of dmitest just dumps data in dictionary order, which can be random every time the dictionary is created. Example:
Chassis Information
Type: Main Server Chassis
Base Board Information
Type: Motherboard
Chassis Information
Manufacturer: Supermicro
System Information
Manufacturer: Supermicro
Base Board Information
Manufacturer: Supermicro
System Information
Product Name: Super Server
Base Board Information
Product Name: X10DRT-B+
Chassis Information
Version: 0123456789
System Information
Version: 0123456789
Base Board Information
Version: 1.01
Processor Information
Version: Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
Processor Information
Version: Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
Passed all tests
This should be changed to look more like this, for ease of reading during review:
System Information
Manufacturer: Supermicro
Product Name: Super Server
Version: 0123456789
Chassis Information
Type: Main Server Chassis
Manufacturer: Supermicro
Version: 0123456789
Base Board Information
Type: Motherboard
Manufacturer: Supermicro
Product Name: X10DRT-B+
Version: 1.01
Processor Information
Version: Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
Version: Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
Passed all tests
Related branches
- Maciej Kisielewski (community): Approve
-
Diff: 238 lines (+77/-42)1 file modifiedbin/dmitest (+77/-42)
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
Modified how the output is displayed. It now will look similar to this:
Base Board Information:
Manufacturer: Gigabyte Technology Co., Ltd.
Product Name: Z170MX-Gaming 5
Serial Number: To be filled by O.E.M. *** Invalid base board serial number!
Type: Motherboard
Version: x.x *** Invalid base board version!
Chassis Information:
Manufacturer: To Be Filled By O.E.M. *** Invalid chassis manufacturer!
Type: Desktop *** Incorrect or unknown server chassis type!
Version: To Be Filled By O.E.M. *** Invalid chassis version!
Processor Information:
Version: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
System Information:
Manufacturer: Gigabyte Technology Co., Ltd.
Product Name: Z170MX-Gaming 5
Serial Number: To be filled by O.E.M. *** Invalid system information serial number!
Version: To be filled by O.E.M. *** Invalid system information version!
Failed 7 tests (see above)