Web Client: Patron Billing Full Details screen is missing column for staff user that created the payment

Bug #1679246 reported by Michele Morgan
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

When viewing a patron's bills screen in the web client, select an entry and choose Actions - Full Details. On this screen the column picker for the Payments section lacks an entry for the staff user that created the payment.

This option exists in the xul client Full Details screen with the label "Staff". Perhaps "Accepting User" or "Accepted By" might be a better label for this field.

Michele Morgan (mmorgan)
description: updated
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Changed in evergreen:
assignee: nobody → Skye Howard (showard1110)
Revision history for this message
Kyle-huckins (kyle-huckins) wrote :

Just as a heads up, Skye was previously working with me on this, but she had to move on to work for a different client, Alex Cautley has picked up development on this and should be pushing a branch shortly, now that he's gained access.

Changed in evergreen:
assignee: Skye Howard (showard1110) → nobody
Revision history for this message
Alex (acautley) wrote :

Pushed branch here (user/acautley/lp1679246-PatronBillingStaffColumn) where it adds the staff and branch info.
There is currently a bug where a ()@ is displayed at the top of the grid object and we are unsure as to why it is appearing. If anyone has ideas as to why it is appearing any feedback would be welcome.

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Alex. The "()@" is the result of a bug in egGrid where static text embedded within an <eg-grid-field>here</> sticks around and remains visible in the DOM. I've seen this a few times before. I'll open a separate LP bug for it.

Revision history for this message
Cesar V (cesardv) wrote :

I have tested this and it works fine. Additionally, I've added a commit on top of the signoff branch below that addresses the display issue in egGrid, the extraneous "()@" eg-grid-field tag text. I simply made a CSS rule to set that tag to display:none. The grid body and its header still display as normal.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/acautley_lp1679246-PatronBillingStaffColumn-signoff

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_0. Thanks, Skye, Alex, and Cesar!

Changed in evergreen:
milestone: none → 3.0.2
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.