NetApp driver for NetApp Unified Driver for Clustered Data ONTAP with Share Server management should include share networks default gateway

[Andreas Merk]

A share create on a NetApp storage with the "NetApp Unified Driver for Clustered Data ONTAP with Share Server management" does not reflect full network settings of the network where the storage is located in (vlan/ipspace).
Very NetApp specific: The created LIFs for the SVM do not contain any gateway settings.

After a code review the settings are also missing from the code. See:
manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py
==================
def _create_lif(self, vserver_client, vserver_name, ipspace_name,
                    node_name, lif_name, network_allocation):
        """Creates LIF for Vserver."""

        port = self._get_node_data_port(node_name)
        ip_address = network_allocation['ip_address']
        netmask = utils.cidr_to_netmask(network_allocation['cidr'])
        vlan = network_allocation['segmentation_id']
        network_mtu = network_allocation.get('mtu')
        mtu = network_mtu or DEFAULT_MTU

        if not vserver_client.network_interface_exists(
                vserver_name, node_name, port, ip_address, netmask, vlan):

            self._client.create_network_interface(
                ip_address, netmask, vlan, node_name, port, vserver_name,
                lif_name, ipspace_name, mtu)

=================
There isn't even a gateway mentioned.
If I get code access I may can fix this on my own.

[Jason Grosso (jgrosso)]

I checked the current code under :
     manila/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py

It appears to be the same:

def _create_lif(self, vserver_client, vserver_name, ipspace_name,
                    node_name, lif_name, network_allocation):
        """Creates LIF for Vserver."""

        port = self._get_node_data_port(node_name)
        ip_address = network_allocation['ip_address']
        netmask = utils.cidr_to_netmask(network_allocation['cidr'])
        vlan = network_allocation['segmentation_id']
        network_mtu = network_allocation.get('mtu')
        mtu = network_mtu or DEFAULT_MTU

        if not vserver_client.network_interface_exists(
                vserver_name, node_name, port, ip_address, netmask, vlan):

            self._client.create_network_interface(
                ip_address, netmask, vlan, node_name, port, vserver_name,
                lif_name, ipspace_name, mtu)

I will investigate further and update asap.

[Goutham Pacha Ravi (gouthamr)]

Hi Andreas / Jason,

Sorry this fell through the cracks, and I'm commenting on a two-year old bug. I think this bug report is a duplicate of https://bugs.launchpad.net/manila/+bug/1612655

And a fix was submitted here: https://review.openstack.org/#/c/478705/ (roughly two years ago) :)

On ONTAP, the gateway is added to the Vserver's routes, and not on individual LIFs; so the code you're looking at wasn't changed as part of that bug fix.

Feel free to create another bug if you're still seeing this issue.

Thanks!
Goutham