END OF EXPEDITION due to time-out schip.cc assertion failed

[Klaus Halfmann]

I played "The Nile" and conquere a (the last) castle for player 1, blue at 11,96
I continued playing for about 5 minutes. then I got:

5: Azurea Sea at 100x 98: END OF EXPEDITION due to time-out
Assertion failed: (get_economy() && get_economy() != expedition_->economy.get()), function exp_cancel, file /Users/klaus/develop/widelands-repo/widelands/src/logic/map_objects/tribes/ship.cc, line 923.

I would assume that the poor ship had no owner and no economy any longer.

Suggestions: such a ship should eihter destory itself on continue its expeditions
(Unless there are no more port spaces).

[Klaus Halfmann (klaus-halfmann)]

After loading this second file I must wait unil 11:41 and the got the crash,
can someone confirm?

[Notabilis (notabilis27)]

Crashes after a few seconds for me, too. But took me some time to figure out that it is a multiplayer game, so of course it doesn't appear in the single player load screen. ;-)

The assertion fails since get_economy() returns a null pointer. A backtrace is attached.

[Notabilis (notabilis27)]

A simple fix seems to be:
 if (get_economy() == nullptr) {
  sink_ship(game);
  return;
 }
in front of the assertion (src/logic/map_objects/tribes/ship.cc:923).
At least, it doesn't crashes any longer. But I haven't really read the code, and I guess some digging should be done why the economy is null anyway.

[GunChleoc (gunchleoc)]

What happens is that grey player has lost their port, so there is no port to return to for the canceled expedition. So, I'd suggest (pseudocode):

if (get_economy() == nullptr) {
  if (has_other_reachable_portdock()) {
    add_ship_to_reachable_portdocks_fleet();
  } else {
    return;
  }
}

do_cancel_expedition;

[GunChleoc (gunchleoc)]

Singleplayer savegame with 2 ports and 2 expeditions for further testing.

[GunChleoc (gunchleoc)]

The code already looks for a reachable port dock, so the final fix is:

If no reachable port dock found:
- Reset Expedition state
- Warning dialog shown to owning player
- AI continues exploring

[GunChleoc (gunchleoc)]

Fixed in build20-rc1