os-collect-config fails to start on empty cache files

[Lukas Bezdicka]

Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: ValueError: No JSON object could be decoded
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: raise ValueError("No JSON object could be decoded")
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: obj, end = self.raw_decode(s, idx=_w(s, 0).end())
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: return _default_decoder.decode(s)
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: **kw)
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib64/python2.7/json/__init__.py", line 290, in load
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: metadata = json.load(f)
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib/python2.7/site-packages/os_collect_config/ec2.py", line 71, in collect
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: content = module.Collector(**collector_kwargs).collect()
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib/python2.7/site-packages/os_collect_config/collect.py", line 166, in collect_all
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: collector_kwargs_map=collector_kwargs_map)
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/lib/python2.7/site-packages/os_collect_config/collect.py", line 262, in __main__
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: sys.exit(__main__())
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: File "/usr/bin/os-collect-config", line 10, in <module>
Mar 28 13:28:28 overcloud-controller-0.localdomain os-collect-config[5224]: Traceback (most recent call last):

https://bugzilla.redhat.com/show_bug.cgi?id=1438096

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444898
Committed: https://git.openstack.org/cgit/openstack/os-collect-config/commit/?id=8566ad549cf0331f79bc37c1dd1ca32727f53790
Submitter: Jenkins
Branch: master

commit 8566ad549cf0331f79bc37c1dd1ca32727f53790
Author: Lukas Bezdicka <email address hidden>
Date: Mon Mar 13 14:20:39 2017 +0100

    Don't fail on non-valid json in cache files

    Resolves: rhbz#1438096
    Closes-Bug: #1678328

    Change-Id: Iee1bb4a7769568cfd3bad8b23c9dff440679ac16
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/455829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/455829
Committed: https://git.openstack.org/cgit/openstack/os-collect-config/commit/?id=17b2b244e1cda17374d5a7aa680285dad9e18951
Submitter: Jenkins
Branch: stable/ocata

commit 17b2b244e1cda17374d5a7aa680285dad9e18951
Author: Lukas Bezdicka <email address hidden>
Date: Mon Mar 13 14:20:39 2017 +0100

    Don't fail on non-valid json in cache files

    Resolves: rhbz#1438096
    Closes-Bug: #1678328

    Change-Id: Iee1bb4a7769568cfd3bad8b23c9dff440679ac16
    Co-Authored-By: Alex Schultz <email address hidden>
    (cherry picked from commit 8566ad549cf0331f79bc37c1dd1ca32727f53790)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-collect-config 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-collect-config 7.0.0 release.