Latest versions of Hugin developpement fail to build

[JeanLucCoulon]

Hi,
I failed to build latest hg versions.
I get the following:

[ 40%] Building CXX object src/hugin_base/CMakeFiles/huginbase.dir/vigra_ext/ImageTransformsGPU.cpp.o
/usr/local/src/hugin/hugin-2016.3.0/src/hugin_base/vigra_ext/ImageTransformsGPU.cpp: In function ‘bool vigra_ext::transformImageGPUIntern(const string&, const string&, int, const string&, const std::vector<double>&, const std::vector<double>&, vigra::Diff2D, const void*, int, int, int, int, const void*, int, vigra::Diff2D, vigra::Diff2D, void*, int, int, int, int, void*, int, bool)’:
/usr/local/src/hugin/hugin-2016.3.0/src/hugin_base/vigra_ext/ImageTransformsGPU.cpp:369:19: error: ‘GL_MAX_RECTANGLE_TEXTURE_SIZE’ was not declared in this scope
     glGetIntegerv(GL_MAX_RECTANGLE_TEXTURE_SIZE, &maxTextureSize);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/hugin_base/CMakeFiles/huginbase.dir/build.make:1358 : la recette pour la cible « src/hugin_base/CMakeFiles/huginbase.dir/vigra_ext/ImageTransformsGPU.cpp.o » a échouée
make[2]: *** [src/hugin_base/CMakeFiles/huginbase.dir/vigra_ext/ImageTransformsGPU.cpp.o] Erreur 1

The lastest version I managed to build was on march, 14th.

Regards

Jean-Luc

[tmodes (tmodes)]

For the next time please provide some more information about your used system (operating system, compiler, and so on).

The main cause for the error is that you are using a very old version of the GLEW library (GLEW versions starting 1.8 from 2011 support this constant). So please update your GLEW library.

Nevertheless I committed a workaround in changeset 028622c32484 for older GLEW versions.

[JeanLucCoulon (jean-luc-coulon-f)]

Sorry for missing to tell you the informations.

Computer:
Intel I7 6700K / 16GB RAM

Distribution:
Debian GNU/Linux sid

Linux: 4.10.6
gcc: 6.3.0

It builds fine with the fix you have committed. But my version of glew is 2.0.0.
It is not so old.

And the define for GL_MAX_RECTANGLE_TEXTURE_SIZE exists in libglew-dev:

rgrep GL_MAX_RECTANGLE_TEXTURE_SIZE /usr/include/GL
/usr/include/GL/glew.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE 0x84F8
/usr/include/GL/glew.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB 0x84F8
/usr/include/GL/glew.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE_EXT 0x84F8
/usr/include/GL/glew.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8
/usr/include/GL/glcorearb.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE 0x84F8
/usr/include/GL/glext.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE 0x84F8
/usr/include/GL/glext.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB 0x84F8
/usr/include/GL/glext.h:#define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8

Regards

Jean-Luc

[tmodes (tmodes)]

That#s strange. GL/glew.h contains

#ifndef GL_VERSION_3_1
#define GL_VERSION_3_1 1

#define GL_TEXTURE_RECTANGLE 0x84F5
#define GL_TEXTURE_BINDING_RECTANGLE 0x84F6
#define GL_PROXY_TEXTURE_RECTANGLE 0x84F7
#define GL_MAX_RECTANGLE_TEXTURE_SIZE 0x84F8
<snip>

So the only cause I can currently imaging is that somewhere on your system GL_VERSION_3_1 gets defined. But I don't know where.