puppet-swift fails on rebalance warnings

[Christian Schwede]

If swift-ring-builder rebalance raises a warning, it will exit with an exit code of 1. That happens for example when rebalancing within min_part_hours, which is by default 1 hour (ie redeploy again with a changed topology within an hour).

If swift-ring-builder raises an error it will use an exit code of 2. Exit codes of 0 and 1 are ok/warnings only, and should not raise a Puppet error therefore.

[Emilien Macchi (emilienm)]

https://review.openstack.org/#/c/451793/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/451793
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=c64538ef8387128226dedbb51cac6548570d84e3
Submitter: Jenkins
Branch: master

commit c64538ef8387128226dedbb51cac6548570d84e3
Author: Christian Schwede <email address hidden>
Date: Thu Mar 30 14:15:28 2017 +0200

    Fix raising an error on rebalance warnings

    If the ring has been rebalanced recently, the next call to rebalance
    will not rebalance again if the time passed is shorter than
    min_part_time. swift-ring-builder returns an exit code of 1 in this
    case, which is a warning, but not a hard error (errors will use an exit
    code of 2).

    It makes sense therefore to expect an exit code of 0 or 1 and only fail
    if it's different.

    Closes-Bug: 1677588
    Change-Id: I03dd075c590344a920099c57b6a7530f103e0ede

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/452535

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452535
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=6d02419ef932b54aca5c60d9d3b1efe67ecfd0f3
Submitter: Jenkins
Branch: stable/ocata

commit 6d02419ef932b54aca5c60d9d3b1efe67ecfd0f3
Author: Christian Schwede <email address hidden>
Date: Thu Mar 30 14:15:28 2017 +0200

    Fix raising an error on rebalance warnings

    If the ring has been rebalanced recently, the next call to rebalance
    will not rebalance again if the time passed is shorter than
    min_part_time. swift-ring-builder returns an exit code of 1 in this
    case, which is a warning, but not a hard error (errors will use an exit
    code of 2).

    It makes sense therefore to expect an exit code of 0 or 1 and only fail
    if it's different.

    Closes-Bug: 1677588
    Change-Id: I03dd075c590344a920099c57b6a7530f103e0ede
    (cherry picked from commit c64538ef8387128226dedbb51cac6548570d84e3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 10.3.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/472253

[Christian Schwede (cschwede)]

Turns out this is also an issue when adding more disks to an existing 3-replica setup. When doing this a rebalance will only move a single replica at a time, and this will create a ring that is not perfectly balanced - and should be rebalanced again after some time. Thus swift-ring-builder exits with an exitcode of 1.

Currently this fails in Newton (because the patch has not yet been backported).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/472253
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=9ffca830e59966f5bfafcd4abf74f710eb9e1d16
Submitter: Jenkins
Branch: stable/newton

commit 9ffca830e59966f5bfafcd4abf74f710eb9e1d16
Author: Christian Schwede <email address hidden>
Date: Thu Mar 30 14:15:28 2017 +0200

    Fix raising an error on rebalance warnings

    If the ring has been rebalanced recently, the next call to rebalance
    will not rebalance again if the time passed is shorter than
    min_part_time. swift-ring-builder returns an exit code of 1 in this
    case, which is a warning, but not a hard error (errors will use an exit
    code of 2).

    It makes sense therefore to expect an exit code of 0 or 1 and only fail
    if it's different.

    Closes-Bug: 1677588
    Change-Id: I03dd075c590344a920099c57b6a7530f103e0ede
    (cherry picked from commit c64538ef8387128226dedbb51cac6548570d84e3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 9.6.0 release.