role order breaks primary role determination

[Alex Schultz]

https://github.com/openstack/tripleo-heat-templates/commit/b1fe2e8d60ad3dcfeec858539343be57115dd698 made the ordering of the roles in role_data.yaml mandatory. This breaks anyone who was previously using custom roles without the controller as the first role. We should add a flag indicating the primary role and leverage that rather than using ordering to determine the primary role.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/451561

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/451561
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=be274f1f49a15aad118a92107b7d04a57a037092
Submitter: Jenkins
Branch: master

commit be274f1f49a15aad118a92107b7d04a57a037092
Author: Alex Schultz <email address hidden>
Date: Wed Mar 29 14:43:45 2017 -0600

    Add tags to roles

    Prior to Ocata, the Controller role was hardcoded for various lookups.
    When we switched to having the primary role name being dynamically
    pulled from the roles_data.yaml using the first role as the primary
    role as part of I36df7fa86c2ff40026d59f02248af529a4a81861, it
    introduced a regression for folks who had previously been using
    a custom roles file without the Controller being listed first.

    Instead of relying on the position of the role in the roles data, this
    change adds the concepts of tags to the role data that can be used when
    looking for specific functionality within the deployment process. If
    no roles are specified with this the tags indicating a 'primary'
    'controller', it will fall back to using the first role listed in the
    roles data as the primary role.

    Change-Id: Id3377e7d7dcc88ba9a61ca9ef1fb669949714f65
    Closes-Bug: #1677374

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.